Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

dobooth
Copy link
Contributor

@dobooth dobooth commented Feb 19, 2019

This PR is a:

  • Content update

Summary

When this pull request is merged, it will...
Add a section about versioning to the MFTF guide.

whatsnew
Added a Versioning topic to the MFTF guide.

@dobooth dobooth added Major Update Significant original updates to existing content 2.2.x 2.3.x Magento 2.3 related changes labels Feb 19, 2019
@dobooth dobooth self-assigned this Feb 19, 2019
@dobooth
Copy link
Contributor Author

dobooth commented Feb 19, 2019

Hi @belbiy I am looking for the proper way to display the large list of Actions at the bottom of the file. Leave it as it, unordered list, table...? Let me know what you think.

Copy link
Contributor

@meker12 meker12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggested changes for content and style

meker12 and others added 6 commits February 20, 2019 09:44
Co-Authored-By: dobooth <dobooth@adobe.com>
Co-Authored-By: dobooth <dobooth@adobe.com>
Co-Authored-By: dobooth <dobooth@adobe.com>
Co-Authored-By: dobooth <dobooth@adobe.com>
Co-Authored-By: dobooth <dobooth@adobe.com>
Co-Authored-By: dobooth <dobooth@adobe.com>
@okolesnyk
Copy link
Member

Hi @dobooth
Create such document is a good idea, but I think you should separate versioning policy for MFTF as a Framework and MFTF Tests to two documents.
Basically MFTF as a framework has own rules for Versioning and MFTF Tests works by different rules.

@dobooth dobooth removed the request for review from belbiy February 20, 2019 17:45
Copy link
Contributor

@meker12 meker12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Provided some additional suggestions.

### X release - major

A major release introduces backward incompatible changes. This MUST increment the major version number.
It can include minor and patch level changes. You must reset the patch and minor version to 0 when you change the major version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It can include minor and patch level changes. You must reset the patch and minor version to 0 when you change the major version.
A major release can also include minor and patch level changes.
You must reset the patch and minor version to 0 when you change the major version.

@dobooth
Copy link
Contributor Author

dobooth commented Feb 21, 2019

running tests

meker12 and others added 5 commits February 21, 2019 14:09
Co-Authored-By: dobooth <dobooth@adobe.com>
Co-Authored-By: dobooth <dobooth@adobe.com>
Co-Authored-By: dobooth <dobooth@adobe.com>
Co-Authored-By: dobooth <dobooth@adobe.com>
@dobooth
Copy link
Contributor Author

dobooth commented Feb 21, 2019

running tests

@dobooth dobooth merged commit 3f3f17a into master Feb 21, 2019
@ghost
Copy link

ghost commented Feb 21, 2019

Hi @dobooth, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth deleted the db_versioning_topic branch February 21, 2019 20:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants