Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

ronak2ram
Copy link
Member

@ronak2ram ronak2ram commented Feb 22, 2019

@magento-cicd2
Copy link
Contributor

An admin must run tests on this PR before it can be merged.

@lorikrell lorikrell self-assigned this Feb 25, 2019
@lorikrell lorikrell self-requested a review February 25, 2019 17:24
@lorikrell lorikrell added Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies 2.3.x Magento 2.3 related changes Community Docs impacted by community code contribution msi-1.1.0 labels Feb 25, 2019
Copy link

@lorikrell lorikrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ronak2ram thank you for the PR!
Checked against the code, and info from MSI.

@lorikrell lorikrell added Technical Updates to the code or processes that alter the technical content of the doc and removed Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies labels Feb 25, 2019
@lorikrell
Copy link

running tests

@lorikrell lorikrell merged commit 84f679a into magento:master Feb 26, 2019
@ghost
Copy link

ghost commented Feb 26, 2019

Hi @ronak2ram, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes Community Docs impacted by community code contribution Partner: Krish TechnoLabs partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants