Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Clarified info about domain delegation #3814

Merged
merged 12 commits into from
Feb 28, 2019

Conversation

meker12
Copy link
Contributor

@meker12 meker12 commented Feb 22, 2019

  • Expanded example showing when domain delegation is required for Fastly service config on Cloud project
  • Added error message returned when domain delegation is needed

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Affected URLs

whatsnew
Updated example for requesting domain delegation when configuring Fastly services for a Magento Commerce Cloud project. See Multiple Fastly accounts and assigned domains.

- Expanded example showing when domain delegation is required for Fastly service config on Cloud project
- Added error message returned when domain delegation is needed
@meker12 meker12 self-assigned this Feb 22, 2019
@meker12 meker12 added 2.1.x 2.2.x 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc labels Feb 22, 2019
Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Bullet list is clunky, but not a show-stopper.


- The {{ site.data.var.ece }} project uses the `storeprod.testweb.com` and `storestaging.testweb.com` subdomains
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These bullet items don't use a consistent pattern

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly for review-- total revision based on technical review

@meker12
Copy link
Contributor Author

meker12 commented Feb 28, 2019

running tests

@meker12 meker12 merged commit 1c5fd7e into master Feb 28, 2019
@ghost
Copy link

ghost commented Feb 28, 2019

Hi @meker12, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@meker12 meker12 added the Internal Dev Differentiates work between community and Magento staff label Feb 28, 2019
@meker12 meker12 deleted the mae-fix-domain-delegation-example branch March 4, 2019 01:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants