Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGECLOUD-3193 github integration #3843

Merged
merged 3 commits into from Mar 1, 2019

Conversation

Projects
None yet
3 participants
@hguthrie
Copy link
Contributor

commented Feb 28, 2019

Bug fix

  • Updated the GitHub Integration topic to add a that warning this overwrites everything.

  • Updated the GitHub Integration topic to align with the latest GitHub interface.

  • Removed old, incorrect graphics. Unfortunately, this required an update to a 2.0 topic to avoid a broken link.

  • Cleaned the formatting for the steps and made more consistent with other integration topics, such as Bitbucket.

  • Requires a technical review pass

whatsnew
Updated the GitHub integration topic.

@hguthrie hguthrie added the Technical label Feb 28, 2019

@hguthrie hguthrie self-assigned this Feb 28, 2019

@hguthrie hguthrie requested a review from jeff-matthews Feb 28, 2019

@hguthrie

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2019

running tests

@hguthrie hguthrie merged commit 1e645d1 into master Mar 1, 2019

2 checks passed

Jenkins Tests passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

commented Mar 1, 2019

Hi @hguthrie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dshevtsov

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2019

@hguthrie please remove a leading space for url of hyperlink at whatsnew.

@hguthrie hguthrie deleted the hg-mc3193-githubintegration branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.