Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Rewrite updates #3859

Merged
merged 3 commits into from Mar 4, 2019

Conversation

Projects
None yet
3 participants
@keharper
Copy link
Contributor

commented Mar 4, 2019

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Summary

This pull request complete Issue #2407. Changes include:

  • Reverting relative_url to canonical_url
  • Adding url_path, 'url_key, and url_rewrites` to the product endpoint page
  • Adding URL rewrite attributes and examples to the UrlRewrite endpoint page
  • Changing the title of the urlResolver page

whatsnew
Added url_path, url_key, and url_rewrites to product endpoint and added URL rewrite attributes and examples to UrlRewrite endpoint

@contribution-survey

This comment has been minimized.

Copy link

commented Mar 4, 2019

Hi @keharper, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper keharper merged commit 3910c0b into 2.3.1-integration Mar 4, 2019

1 check passed

licence/cla Contributor License Agreement is signed.
Details

@keharper keharper referenced this pull request Mar 4, 2019

Closed

Add/update GraphQL URL Rewrite docs #2407

4 of 12 tasks complete

@keharper keharper deleted the kh_url-resolver branch Mar 5, 2019

@dshevtsov

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

@keharper
There is missing whatsnew for the Major Update PR.

@dshevtsov

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

@keharper please fix formatting in the whatsnew description

@keharper

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

@dshevtsov Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.