This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Service contracts MUST NOT rely on the execution context #3870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anton Kaplia seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
|
An admin must run tests on this PR before it can be merged. |
dshevtsov
reviewed
Mar 5, 2019
| @@ -610,6 +610,8 @@ class View extends Template | |||
|
|
|||
| 6.4.4.12. Any customizations to the domain/business logic MUST be executed on the Service Contracts layer, and so MUST be declared in the `global` area of configuration. | |||
|
|
|||
| 6.4.4.13. Service contracts MUST NOT rely on the execution context(application area). Services implementation MUST NOT know about the application state. | |||
There was a problem hiding this comment.
Suggested change
| 6.4.4.13. Service contracts MUST NOT rely on the execution context(application area). Services implementation MUST NOT know about the application state. | |
| 6.4.4.13. A service contract MUST NOT rely on the execution context (application area). The service implementation MUST NOT depend on the application state. |
YevSent
approved these changes
Mar 5, 2019
dshevtsov
reviewed
Mar 5, 2019
| @@ -610,6 +610,8 @@ class View extends Template | |||
|
|
|||
| 6.4.4.12. Any customizations to the domain/business logic MUST be executed on the Service Contracts layer, and so MUST be declared in the `global` area of configuration. | |||
|
|
|||
| 6.4.4.13. Service contracts MUST NOT rely on the execution context (application area). Services implementation MUST NOT know about the application state. | |||
There was a problem hiding this comment.
Suggested change
| 6.4.4.13. Service contracts MUST NOT rely on the execution context (application area). Services implementation MUST NOT know about the application state. | |
| 6.4.4.13. A service contract MUST NOT rely on execution context (application area). The service implementation MUST NOT depend on the application state. |
melnikovi
reviewed
Mar 5, 2019
| @@ -610,6 +610,8 @@ class View extends Template | |||
|
|
|||
| 6.4.4.12. Any customizations to the domain/business logic MUST be executed on the Service Contracts layer, and so MUST be declared in the `global` area of configuration. | |||
|
|
|||
| 6.4.4.13. Service contracts MUST NOT rely on the execution context (application area). Services implementation MUST NOT know about the application state. | |||
There was a problem hiding this comment.
Should it be SHOULD or can it be applied in all cases today?
There was a problem hiding this comment.
for all cases, for all service contracts
|
running tests |
|
Hi @akaplya, thank you for your contribution! |
dshevtsov
added
Major Update
|
It would be helpful to add a reason for the rule to the document, or link to a resource explaining the rationale behind it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service contracts MUST NOT rely on the execution context
whatsnew
Added a technical guideline 6.4.4.13.