Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

wojtekn
Copy link
Contributor

@wojtekn wojtekn commented Mar 9, 2019

This PR is a:

  • Content fix or rewrite

Summary

When this pull request is merged, it will fix incorrect command call shown on CLI commands docs. Docs mention "bin/magento --list" command as one to list available commands, but this call fails. The proper call would be "bin/magento list".

Additional information

List all affected URLs

https://devdocs.magento.com/guides/v2.0/extension-dev-guide/cli-cmds/cli-naming-guidelines.html
https://devdocs.magento.com/guides/v2.1/extension-dev-guide/cli-cmds/cli-naming-guidelines.html
https://devdocs.magento.com/guides/v2.2/extension-dev-guide/cli-cmds/cli-naming-guidelines.html
https://devdocs.magento.com/guides/v2.3/extension-dev-guide/cli-cmds/cli-naming-guidelines.html

whatsnew
Fixed the Command name in the Command Naming Guidelines.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 9, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added Partner: Mediotype PR created by Mediotype partner partners-contribution PR created by Magento partner labels Mar 9, 2019
@magento-cicd2
Copy link
Contributor

An admin must run tests on this PR before it can be merged.

@osrecio osrecio self-assigned this Mar 11, 2019
@osrecio osrecio self-requested a review March 11, 2019 09:28
@dobooth dobooth self-assigned this Mar 11, 2019
@dobooth dobooth self-requested a review March 11, 2019 20:32
@dobooth dobooth added Technical Updates to the code or processes that alter the technical content of the doc 2.1.x 2.2.x 2.3.x Magento 2.3 related changes labels Mar 11, 2019
@dobooth
Copy link
Contributor

dobooth commented Mar 11, 2019

running tests

@dobooth dobooth merged commit 7a2604f into magento:master Mar 11, 2019
@ghost
Copy link

ghost commented Mar 11, 2019

Hi @wojtekn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team removed the Technical Updates to the code or processes that alter the technical content of the doc label Mar 11, 2019
@wojtekn wojtekn deleted the fix_list_command_call_in_cli_guidelines branch March 11, 2019 22:00
@jeff-matthews jeff-matthews added the Technical Updates to the code or processes that alter the technical content of the doc label Mar 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Partner: Mediotype PR created by Mediotype partner partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants