Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

erikmarr
Copy link
Contributor

@erikmarr erikmarr commented Mar 11, 2019

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Summary

When this pull request is merged, it will close #3895.

List all affected URLs

  • New graphql topic under the reference section

whatsnew
Added a new topic about the document directory endpoint

@erikmarr erikmarr self-assigned this Mar 11, 2019
@erikmarr erikmarr requested a review from keharper March 11, 2019 17:26
@erikmarr erikmarr added Major Update Significant original updates to existing content Community Docs impacted by community code contribution xx2.3.1 Magento 2.3.1 changes labels Mar 11, 2019
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending some minor changes

title: Directory endpoint
---

To retrieve country and regional directory information, use the `country`, `countries`, and `currency` endpoints.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To retrieve country and regional directory information, use the `country`, `countries`, and `currency` endpoints.
To retrieve country and regional directory information, use the `country`, `countries`, and `currency` queries.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

```

## Countries
Use the `countries` endpoint to return all countries in which the entity can do business.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use the `countries` endpoint to return all countries in which the entity can do business.
Use the `countries` query to return all countries in which the entity can do business.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

```

## Currency
Use the `currency` endpoint to return information about the store's currency configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use the `currency` endpoint to return information about the store's currency configuration.
Use the `currency` query to return information about the store's currency configuration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@erikmarr erikmarr merged commit 31d848e into 2.3.1-integration Mar 11, 2019
@ghost
Copy link

ghost commented Mar 11, 2019

Hi @erikmarr, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@erikmarr erikmarr deleted the em_graphql-3895 branch March 11, 2019 19:15
@dshevtsov
Copy link
Collaborator

@erikmarr
There is missing whatsnew for the Major Update PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community Docs impacted by community code contribution Major Update Significant original updates to existing content xx2.3.1 Magento 2.3.1 changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants