Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

jeff-matthews
Copy link
Contributor

@jeff-matthews jeff-matthews commented Mar 20, 2019

This PR is a:

  • [x ] New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

When this pull request is merged, it will add release notes for the Magento Open Source 2.1.17 and Magento Commerce 2.1.17 releases.

whatsnew
The Magento Open Source 2.1.17 Release Notes and  Magento Commerce 2.1.17 Release Notes provide detailed information about the Magento Open Source 2.1.17 and Magento Commerce 2.1.17 releases.

@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jeff-matthews
❌ Jeanne Frontain


Jeanne Frontain seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@jeff-matthews jeff-matthews self-assigned this Mar 20, 2019
@jeff-matthews jeff-matthews added Major Update Significant original updates to existing content 2.1.17 labels Mar 20, 2019
@jeff-matthews jeff-matthews merged commit d77fed4 into 2.3.1-integration Mar 20, 2019
@ghost
Copy link

ghost commented Mar 20, 2019

Hi @jeff-matthews, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dshevtsov
Copy link
Collaborator

To follow devdocs file naming convention, the files should be renamed as shown below:

  • guides/v2.1/release-notes/ReleaseNotes2.1.17CE.md - > guides/v2.1/release-notes/2.1.17-open-source.md
  • guides/v2.1/release-notes/ReleaseNotes2.1.17EE.md -> guides/v2.1/release-notes/2.1.17-commerce.md

It would make sense to store different editions in different folders:

  • guides/v2.1/release-notes/open-source/2.1.17.md
  • guides/v2.1/release-notes/commerce/2.1.17.md

@dshevtsov
Copy link
Collaborator

@jeff-matthews please move whatsnew at the very end of the PR description

@jeff-matthews jeff-matthews deleted the release-notes-2-1-17 branch March 26, 2019 13:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants