Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Adding a code sample of how the menu widget can be initialized and used. #4026

Merged
merged 9 commits into from
Apr 11, 2019
Merged

Adding a code sample of how the menu widget can be initialized and used. #4026

merged 9 commits into from
Apr 11, 2019

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Mar 25, 2019 •
edited by bdenham
Loading

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Summary

When this pull request is merged, it will provide an example of how the menu widget can be used and how the widget's options can be passed during initialization.

Additional information

List all affected URLs

Related Issue: #1276

whatsnew
Added code sample for Menu widget.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@eduard13
Copy link
Contributor Author

eduard13 commented Mar 25, 2019 •
edited
Loading

Looks like the 2.0 isn't supported anymore, so those changes were removed.
Thank you.

@lorikrell lorikrell added the Major Update Significant original updates to existing content label Mar 26, 2019
@bdenham bdenham self-requested a review April 2, 2019 15:37
@bdenham bdenham self-assigned this Apr 2, 2019
@eduard13
Copy link
Contributor Author

@bdenham is there any update on this one? Maybe there is needed some additional info from my side?
Thank you.

@bdenham bdenham requested a review from bassplayer7 April 10, 2019 22:37
bassplayer7
bassplayer7 approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@bassplayer7 bassplayer7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

bdenham
bdenham approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@bdenham bdenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the example, @eduard13! (I made some grammar, spelling, and punctuation changes.)

@bdenham
Copy link
Contributor

bdenham commented Apr 11, 2019

running tests

@bdenham
Copy link
Contributor

bdenham commented Apr 11, 2019 •
edited
Loading

Hey @eduard13, looks like you're missing images for versions 2.2 and 2.3. Can you push them up and I'll run the tests again. Thanks.

Here are the links that failed:

  • internal image /guides/v2.2/javascript-dev-guide/widgets/images/menu-widget-result.png does not exist
    • _site/guides/v2.2/javascript-dev-guide/widgets/widget_menu.html (line 2276)
  • internal image /guides/v2.3/javascript-dev-guide/widgets/images/menu-widget-result.png does not exist
    • _site/guides/v2.3/javascript-dev-guide/widgets/widget_menu.html (line 2332)

@eduard13
Copy link
Contributor Author

eduard13 commented Apr 11, 2019 •
edited
Loading

Hey @bdenham, thank you for letting me know, I couldn't see what was wrong. I've just pushed them now.

@bdenham
Copy link
Contributor

bdenham commented Apr 11, 2019

Awesome, running tests now. Will merge when complete. Thanks!

@dobooth
Copy link
Contributor

dobooth commented Apr 11, 2019

running tests

@bdenham bdenham merged commit 4b94d15 into magento:master Apr 11, 2019
@ghost
Copy link

ghost commented Apr 11, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dshevtsov
Copy link
Collaborator

@bdenham please add whatsnew when you work with a PR with the Major update label.

@dshevtsov
Copy link
Collaborator

@bdenham add labels to indicate the affected versions.

@bdenham bdenham added the 2.1.x label Apr 15, 2019
@bdenham bdenham added 2.2.x 2.3.x Magento 2.3 related changes labels Apr 15, 2019
@jeff-matthews jeff-matthews added the Special achievement High-value contributions that earn higher rewards and special attention label May 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@bassplayer7 bassplayer7 bassplayer7 approved these changes

@bdenham bdenham bdenham approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@bdenham bdenham

Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Atwix partners-contribution PR created by Magento partner Special achievement High-value contributions that earn higher rewards and special attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@eduard13 @devops-devdocs @bdenham @dobooth @dshevtsov @bassplayer7 @jeff-matthews @lorikrell @magento-engcom-team @shrielenee