This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Replace deprecated attribute name #4078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Krish TechnoLabs
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
|
Hi @mageprince, thank you for your contribution! |
|
@keharper I have replaced a deprecated attribute in develop branch which is created for 2.3.2 and I checked #3925 @mage2pratik has missed adding an attribute so I have created this PR based on his PR. So can you please reopen this and proceed further? |
|
An admin must run tests on this PR before it can be merged. |
keharper
added
xx2.3.1
keharper
added
Technical
keharper
approved these changes
Apr 23, 2019
Listed canonical_url as deprecated and general cleanup.
|
Hi @mageprince, thank you for your contribution! |
|
Thanks @mageprince |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
Summary
When this pull request is merged, it will replace deprecated attribute
Additional information
List all affected URLs
https://devdocs.magento.com/guides/v2.3/graphql/reference/url-resolver.html