Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

dshevtsov
Copy link
Collaborator

@dshevtsov dshevtsov commented Mar 28, 2019

This PR is a:

Content update

Summary

When this pull request is merged, it will:

  • rename topics Third-party licenses to Packages
  • add magento packages to the topics

Additional information

Internal ticket: MAGEDOC-3606

whatsnew
Changed Third-party licenses topics to Packages and added a section with magento/-specific dependencies.

@dshevtsov dshevtsov added 2.x Major Update Significant original updates to existing content labels Mar 28, 2019
@dshevtsov dshevtsov self-assigned this Mar 28, 2019
@keharper
Copy link
Contributor

I have no specific comments, but I'd like to see a test build.

@dshevtsov
Copy link
Collaborator Author

@keharper we do not share internal previews at public repositories.
See corresponding ticket in Additional information for any internal resources.

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See minor editorial suggestions

jeff-matthews and others added 2 commits March 29, 2019 10:56
Co-Authored-By: dshevtsov <12731225+dshevtsov@users.noreply.github.com>
Co-Authored-By: dshevtsov <12731225+dshevtsov@users.noreply.github.com>
@dshevtsov dshevtsov requested a review from buskamuza March 29, 2019 15:59
@dshevtsov dshevtsov requested review from hguthrie and meker12 March 29, 2019 17:12
@dshevtsov
Copy link
Collaborator Author

dshevtsov commented Mar 29, 2019

@hguthrie, @meker12 what do you think about moving the Cloud packages topic to the Cloud Guide?

Copy link
Contributor

@meker12 meker12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hguthrie, @meker12 what do you think about moving the Cloud packages topic to the Cloud Guide?

@hguthrie and I were discussing. For now, it's best to leave this information where people can find it in one place. Also, we're trying to understand the doc impact of the recent changes to Cloud offerings announced at the Adobe summit.

meker12 and others added 4 commits March 29, 2019 15:59
Co-Authored-By: dshevtsov <12731225+dshevtsov@users.noreply.github.com>
Co-Authored-By: dshevtsov <12731225+dshevtsov@users.noreply.github.com>
Co-Authored-By: dshevtsov <12731225+dshevtsov@users.noreply.github.com>
@dshevtsov
Copy link
Collaborator Author

running tests

@ghost
Copy link

ghost commented Mar 29, 2019

Hi @dshevtsov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dshevtsov dshevtsov merged commit 7b8716c into master Mar 29, 2019
@dshevtsov dshevtsov deleted the ds_add-magento-packages branch March 29, 2019 21:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants