Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

hguthrie
Copy link
Contributor

@hguthrie hguthrie commented Apr 10, 2019

This PR updated the Application topic so that the web property shows the latest default set of web accessible locations. The rules for robots.txt file are different for 2.1.11 and later.

  • Updated the default locations for 2.1.11 and later
  • added note about different rule for For versions 2.1.4 to 2.1.10
  • fixed a problem with some notes not showing properly
  • converted hard-to-read list into a table

whatsnew
Updated the default web accessible locations with the latest rules for the robots.txt file.

@hguthrie hguthrie self-assigned this Apr 10, 2019
@hguthrie hguthrie added 2.1.x 2.2.x Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc labels Apr 10, 2019
Copy link
Contributor

@meker12 meker12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggested clarifications and a question about use of path versus URL


Our default configuration allows the following:

- From the root (`/`) path, only web, media, and `robots.txt` files can be accessed
- From the root (`/`) path, only web, media, and `robots.txt` files can be accessed
For versions 2.1.4 to 2.1.10, the rules entry for the `robots.txt` file:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For versions 2.1.4 to 2.1.10, the rules entry for the `robots.txt` file:
For versions 2.1.4 to 2.1.10, the configuration includes the following rules entry for the `robots.txt` file:

@@ -79,18 +79,20 @@ The `web` property defines how your application is exposed to the web (in HTTP).

You can specify the following attributes for the `web` property:

- `document_root`: The path relative to the root of the application that is exposed on the web. Typical values include `/public` and `/web`.
- `passthru`: The URL used in the event a static file or PHP file could not be found. This would typically be your applications front controller, often `/index.php` or `/app.php`.
- `index_files`: To use a static file (for example, `index.html`) to serve your application. This key expects a collection. For this to work, the static file(s) should be included in your whitelist. For example, to use a file named `index.html` as an index file, your whitelist should include an element that matches the filename, like `- \.html$`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index_files | Specifies a static file (for example, index.html) to serve your application. This key expects a collection. For this to work, the static file(s) should be included in your whitelist. For example, to use a file named index.html as an index file, ensure that your whitelist includes an element that matches the filename, like - \.html$.

@hguthrie
Copy link
Contributor Author

running tests

@ghost
Copy link

ghost commented Apr 12, 2019

Hi @hguthrie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@hguthrie hguthrie merged commit ced7228 into master Apr 12, 2019
@hguthrie hguthrie deleted the hg-mc3409-robots branch April 12, 2019 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants