Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGEDOC-3672: Magento extensions #4214

Merged
merged 22 commits into from
Apr 15, 2019
Merged

MAGEDOC-3672: Magento extensions #4214

merged 22 commits into from
Apr 15, 2019

Conversation

jeff-matthews
Copy link
Contributor

@jeff-matthews jeff-matthews commented Apr 10, 2019

Scope of this PR

  • New Topic: Entirely new documents

Purpose of this PR (required)

Add a new section for installing MDEs like Amazon Sales Channel and Google Shopping Ads Channel and move MSI and B2B topics there.

Affected URLs (required)

whatsnew
Add a new Magento Extensions section for installing Magento-developed extensions, such as Google Shopping ads Channel. Moved existing installation docs for B2B and MSI to new section.

@jeff-matthews jeff-matthews added the New Topic A major update published as an entirely new document label Apr 10, 2019
@jeff-matthews jeff-matthews self-assigned this Apr 10, 2019
@lorikrell lorikrell added the Internal Dev Differentiates work between community and Magento staff label Apr 10, 2019
@lorikrell
Copy link

I'll push updates to add info and make changes.

Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw B2B was affected, so here's a surprise review.

extensions/b2b/index.md Outdated Show resolved Hide resolved
extensions/google-shopping-ads/index.md Outdated Show resolved Hide resolved
extensions/google-shopping-ads/index.md Show resolved Hide resolved
extensions/google-shopping-ads/index.md Show resolved Hide resolved
extensions/google-shopping-ads/index.md Outdated Show resolved Hide resolved
extensions/amazon-sales/index.md Outdated Show resolved Hide resolved
extensions/amazon-sales/index.md Outdated Show resolved Hide resolved
extensions/b2b/index.md Outdated Show resolved Hide resolved
extensions/b2b/index.md Outdated Show resolved Hide resolved
extensions/b2b/index.md Show resolved Hide resolved
keharper and others added 5 commits April 11, 2019 09:11
Co-Authored-By: lorikrell <lkrell@adobe.com>
Co-Authored-By: lorikrell <lkrell@adobe.com>
Co-Authored-By: lorikrell <lkrell@adobe.com>
Co-Authored-By: lorikrell <lkrell@adobe.com>
Co-Authored-By: lorikrell <lkrell@adobe.com>
@lorikrell
Copy link

Thanks Kevin! Going through and updating! For anyone peeking into these, the Google and Amazon content is ported from User Guide. Giving it a cleaning currently for DevDocs styles. 👍

@lorikrell lorikrell self-assigned this Apr 12, 2019
@jeff-matthews jeff-matthews marked this pull request as ready for review April 15, 2019 13:10
extensions/index.md Outdated Show resolved Hide resolved
extensions/index.md Outdated Show resolved Hide resolved
Copy link

@lorikrell lorikrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All content updated and reviewed.

@lorikrell lorikrell added the 2.x label Apr 15, 2019
@lorikrell
Copy link

running tests

@lorikrell
Copy link

running tests

@lorikrell lorikrell merged commit 7c115a9 into master Apr 15, 2019
@ghost
Copy link

ghost commented Apr 15, 2019

Hi @jeff-matthews, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@lorikrell lorikrell deleted the MAGEDOC-3672-install-MDEs branch April 15, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Internal Dev Differentiates work between community and Magento staff New Topic A major update published as an entirely new document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants