-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Adding a code sample of how the modal widget can be initialized #4269
Conversation
An admin must run tests on this PR before it can be merged. |
Hi @jeff-matthews, the suggested changes were applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eduard13, are all three image files the same? If so, we only need one image and it should be saved to devdocs/common/images/
. there's no need to replicate the same image.
@jeff-matthews, yes they are. Interesting, I didn't know about that, thank you for noticing. |
Perfect @eduard13! Thank you for taking the extra step to optimize the image as well. We haven't had good contributor guidelines around doing that in the past, but we'll create some soon. Thank you for being proactive. |
running tests |
Tests failed. Here's the log:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of adding the image to common/images/js/widget, please add to common/images/widget.
Co-Authored-By: eduard13 <e.chitoraga@atwix.com>
running tests |
@jeff-matthews now it should be fine I guess. |
Yes, I think so too. Almost finished running tests. |
running tests |
Hi @eduard13, thank you for your contribution! |
Purpose of this PR
This PR is an improvement of Modal widget, which provides an example of how the modal can be used and how the widget's options can be passed during initialization. Also the example's result preview is provided.
Moreover, an additional (important) widget's option was added to the documentation.
Affected URLs
whatsnew
Added a new code sample showing how to initialize a modal widget and pass options to it.