Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Adding a code sample of how the accordion widget can be used #4304

Merged
merged 3 commits into from
Apr 24, 2019

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Apr 21, 2019

Purpose of this PR

This PR is an improvement of Accordion widget, which provides an example of how the accordion can be used and how the widget's options can be passed during initialization.
Also the example's result preview is provided.

Affected URLs

whatsnew
Added a new code sample showing how to use the accordion widget.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@osrecio osrecio self-assigned this Apr 22, 2019
Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eduard13 for your PR.

I think is a good example for new and veteran developers.

@jeff-matthews jeff-matthews added the Major Update Significant original updates to existing content label Apr 24, 2019
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See minor editorial suggestion

@jeff-matthews jeff-matthews added 2.1.x 2.2.x 2.3.x Magento 2.3 related changes labels Apr 24, 2019
Co-Authored-By: eduard13 <e.chitoraga@atwix.com>
@eduard13
Copy link
Contributor Author

Thank you @jeff-matthews, it was adjusted.

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eduard13!

@jeff-matthews
Copy link
Contributor

running tests

@jeff-matthews jeff-matthews merged commit c095d2b into magento:master Apr 24, 2019
@ghost
Copy link

ghost commented Apr 24, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Atwix partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants