This repository was archived by the owner on Nov 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Improving the dropdown dialog widget documentation #4346
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd an example of initialization.
An admin must run tests on this PR before it can be merged. |
ronak2ram
approved these changes
Apr 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the codebase file, these changes are correct.
jeff-matthews
suggested changes
Apr 30, 2019
Hi @jeff-matthews, you're right. I've jut moved it into the right folder. |
jeff-matthews
approved these changes
May 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eduard13!
running tests |
Hi @eduard13, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
2.1.x
2.2.x
2.3.x
Magento 2.3 related changes
Major Update
Significant original updates to existing content
Partner: Atwix
partners-contribution
PR created by Magento partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR improves the dropdown widget documentation with some useful options which can be used on widget's initialization, also a good example which can be used for widget's initialization was provided.
Affected URLs
Links to source code
whatsnew
Added a new code example showing how to initialize and pass options to the dropdown dialog widget.