Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Apr 25, 2019

Purpose of this PR

This PR improves the dropdown widget documentation with some useful options which can be used on widget's initialization, also a good example which can be used for widget's initialization was provided.

Affected URLs

Links to source code

whatsnew
Added a new code example showing how to initialize and pass options to the dropdown dialog widget.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@ronak2ram ronak2ram self-requested a review April 25, 2019 10:43
@ronak2ram ronak2ram self-assigned this Apr 25, 2019
Copy link
Member

@ronak2ram ronak2ram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the codebase file, these changes are correct.

@jeff-matthews jeff-matthews added 2.1.x 2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content small changes labels Apr 30, 2019
@eduard13
Copy link
Contributor Author

eduard13 commented May 1, 2019

Hi @jeff-matthews, you're right. I've jut moved it into the right folder.
Thank you.

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eduard13!

@dobooth
Copy link
Contributor

dobooth commented May 3, 2019

running tests

@dobooth dobooth merged commit 94a49bc into magento:master May 3, 2019
@ghost
Copy link

ghost commented May 3, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Atwix partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants