Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Adding code sample example for the use of collapsible widget #4351

Merged
merged 4 commits into from
May 2, 2019

Conversation

ParthBrahmbhatt
Copy link
Contributor

@ParthBrahmbhatt ParthBrahmbhatt commented Apr 25, 2019

Purpose of this PR

This PR is an improvement of Collapsible widget, which provide an example of how the collapsible can be used and how the widget's options can be passed during initialization.

Affected URLs

whatsnew
Added a code example section to Collapsible Widget.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@ronak2ram ronak2ram self-requested a review April 25, 2019 19:00
@ronak2ram ronak2ram self-assigned this Apr 25, 2019
@dobooth
Copy link
Contributor

dobooth commented Apr 29, 2019

Hi @ParthBrahmbhatt Thanks for the contribution. Looks like the heading is wrong. It's important to follow header order. I think your code sample should be ####.

@ParthBrahmbhatt
Copy link
Contributor Author

Hi @dobooth
I have updated the header format as per your suggetion.

@dobooth dobooth added 2.1.x 2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content labels May 2, 2019
@dobooth
Copy link
Contributor

dobooth commented May 2, 2019

running tests

@dobooth dobooth merged commit 4ed489f into magento:master May 2, 2019
@ghost
Copy link

ghost commented May 2, 2019

Hi @ParthBrahmbhatt, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Krish TechnoLabs partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants