Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented May 1, 2019

Purpose of this PR

This PR describes another way of JS debugging by using DevTools, by providing the needed steps and using a small uiComponent as sample.

Affected URLs

whatsnew
Added instructions for debugging a UI component using Chrome DevTools.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this May 2, 2019
@rogyar
Copy link
Contributor

rogyar commented May 3, 2019

From the technical standpoint, the provided update is correct

@rogyar
Copy link
Contributor

rogyar commented May 3, 2019

@eduard13 thank you for the cool tutorial

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great contribution @eduard13! Thanks. I only have a few minor editorial suggestions.

@jeff-matthews jeff-matthews added 2.1.x 2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content small changes labels May 6, 2019
@eduard13
Copy link
Contributor Author

eduard13 commented May 6, 2019

Hi @jeff-matthews thank you for your suggestions, they were applied for both versions.

@eduard13
Copy link
Contributor Author

Hi @jeff-matthews is there anything else that I should do here?
Thank you.

@jeff-matthews
Copy link
Contributor

@eduard13, nope! I'll test and merge.

@jeff-matthews
Copy link
Contributor

running tests

@jeff-matthews jeff-matthews merged commit 76ad89c into magento:master May 10, 2019
@ghost
Copy link

ghost commented May 10, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@eduard13 eduard13 deleted the patch-debugging-js branch July 27, 2019 06:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Atwix partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants