This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Improving the writing testable code section #4437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Atwix
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
rogyar
suggested changes
May 7, 2019
rogyar
approved these changes
May 7, 2019
dobooth
approved these changes
May 7, 2019
|
running tests |
|
Hi @eduard13, thank you for your contribution! |
|
@dobooth please add whatsnew |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) improves the documentation of how to write testable code, by providing some simple of bad and good examples. Also it explains why it needs to keep it simple and maintainable.
Affected DevDocs pages
whatsnew
Added "Each function has one single purpose" section to Writing Testable Code.