Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

atwixfirster
Copy link
Contributor

Purpose of this pull request

Per @dobooth , notice in #4274 we should use <magento_root> instead of <your Magento install dir> in the documentation.

Affected DevDocs pages

Thank you!

…_root>`

https://devdocs.magento.com/guides/v2.0/install-gde/install/sample-data-after-composer.html
https://devdocs.magento.com/guides/v2.1/install-gde/install/sample-data-after-composer.html
https://devdocs.magento.com/guides/v2.2/install-gde/install/sample-data-after-composer.html
https://devdocs.magento.com/guides/v2.3/install-gde/install/sample-data-after-composer.html
https://devdocs.magento.com/guides/v2.0/config-guide/config/config-files.html
https://devdocs.magento.com/guides/v2.1/config-guide/config/config-files.html
https://devdocs.magento.com/guides/v2.2/config-guide/config/config-files.html
https://devdocs.magento.com/guides/v2.3/config-guide/config/config-files.html
https://devdocs.magento.com/guides/v2.0/comp-mgr/trouble/cman/cron.html
https://devdocs.magento.com/guides/v2.1/comp-mgr/trouble/cman/cron.html
https://devdocs.magento.com/guides/v2.2/comp-mgr/trouble/cman/cron.html
https://devdocs.magento.com/guides/v2.3/comp-mgr/trouble/cman/cron.html
https://devdocs.magento.com/guides/v2.0/install-gde/trouble/readiness/tshoot_rc_cron.html
https://devdocs.magento.com/guides/v2.1/install-gde/trouble/readiness/tshoot_rc_cron.html
https://devdocs.magento.com/guides/v2.2/install-gde/trouble/readiness/tshoot_rc_cron.html
https://devdocs.magento.com/guides/v2.3/install-gde/trouble/readiness/tshoot_rc_cron.html
https://devdocs.magento.com/guides/v2.0/comp-mgr/trouble/cman/component-depend.html
https://devdocs.magento.com/guides/v2.1/comp-mgr/trouble/cman/component-depend.html
https://devdocs.magento.com/guides/v2.2/comp-mgr/trouble/cman/component-depend.html
https://devdocs.magento.com/guides/v2.3/comp-mgr/trouble/cman/component-depend.html
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this May 9, 2019
cd <magento_root>
```

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have doubts about wrapping every command into a separate tag. However, they should be executed step by step. So, it's ok.

Copy link
Contributor Author

@atwixfirster atwixfirster May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing, @rogyar .

Regarding @dobooth comment such format is ok.

01

Thank you!

@dobooth dobooth self-assigned this May 9, 2019
@dobooth
Copy link
Contributor

dobooth commented May 9, 2019

running tests

@dobooth dobooth merged commit a9cf96b into magento:master May 9, 2019
@ghost
Copy link

ghost commented May 9, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dobooth dobooth added 2.1.x 2.2.x 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc labels May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Partner: Atwix partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants