Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

MAGEDOC-3687: Amazon Sales Channel GA docs #4472

Merged
merged 4 commits into from
May 10, 2019

Conversation

hickskenh
Copy link
Contributor

Purpose of this pull request

This pull request (PR) removed beta banner and updated availability for asc ga

Affected DevDocs pages

whatsnew
Published Amazon Sales Channel documentation for GA release.

removed beta banner and uipdated availability for asc ga
@hickskenh hickskenh changed the title 3687 devdoc update MAGEDOC-3687: Amazon Sales Channel GA docs May 9, 2019
Copy link

@lorikrell lorikrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

removed incorrect addition of 2.2.6+ for ASC
@lorikrell lorikrell added 2.2.x 2.3.x Magento 2.3 related changes Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc labels May 9, 2019
@jeff-matthews jeff-matthews requested review from lorikrell and removed request for lorikrell May 9, 2019 20:44
@jeff-matthews jeff-matthews added Major Update Significant original updates to existing content and removed Technical Updates to the code or processes that alter the technical content of the doc Internal Dev Differentiates work between community and Magento staff labels May 9, 2019
@jeff-matthews jeff-matthews self-requested a review May 9, 2019 20:53
@jeff-matthews jeff-matthews added 2.0.0-asc and removed 2.2.x 2.3.x Magento 2.3 related changes labels May 9, 2019
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggested updates

Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
@jeff-matthews
Copy link
Contributor

Wait for authorization before running tests and merging.

@hickskenh
Copy link
Contributor Author

running tests

@hickskenh hickskenh merged commit 8ff6b27 into master May 10, 2019
@ghost
Copy link

ghost commented May 10, 2019

Hi @hickskenh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@hickskenh hickskenh deleted the MAGEDOC-3687-remove-beta-banner branch May 10, 2019 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants