Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented May 9, 2019

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@ronak2ram ronak2ram self-requested a review May 10, 2019 04:19
@ronak2ram ronak2ram self-assigned this May 10, 2019
Copy link
Member

@ronak2ram ronak2ram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @atwixfirster
Thanks for your contributions. This PR is very helpful to the developer for understanding the Page layout.

@atwixfirster
Copy link
Contributor Author

Hi @atwixfirster
Thanks for your contributions. This PR is very helpful to the developer for understanding the Page layout.

Thanks for approve, @ronak2ram !

With my pleasure 😊

@jeff-matthews jeff-matthews added 2.1.x 2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content labels May 10, 2019
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please accept the suggested edits

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atwixfirster!

@jeff-matthews
Copy link
Contributor

running tests

@jeff-matthews
Copy link
Contributor

Tests failed. Here's the log:

+ rake test:cicd
�[35mChecking links with htmlproofer...�[0m
Running ["LinkChecker::DoubleSlashCheck", "ImageCheck", "LinkCheck", "ScriptCheck"] on ["_site"] on *.html... 

Ran on 4105 files!

- internal image /guides/v2.1/frontend-dev-guide/images/version.png does not exist
  *  _site/guides/v2.1/frontend-dev-guide/layouts/layout-types.html (line 315)
- internal image /guides/v2.2/frontend-dev-guide/images/version.png does not exist
  *  _site/guides/v2.2/frontend-dev-guide/layouts/layout-types.html (line 315)
- internal image /guides/v2.3/frontend-dev-guide/images/version.png does not exist
  *  _site/guides/v2.3/frontend-dev-guide/layouts/layout-types.html (line 315)
rake aborted!
HTML-Proofer found 3 failures!```

@jeff-matthews
Copy link
Contributor

running tests

@jeff-matthews jeff-matthews merged commit bff7b4a into magento:master May 10, 2019
@ghost
Copy link

ghost commented May 10, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Atwix partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants