Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

magento/devdocs#: New topic. Product layouts #4489

Merged
merged 6 commits into from
May 28, 2019
Merged

magento/devdocs#: New topic. Product layouts #4489

merged 6 commits into from
May 28, 2019

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented May 11, 2019 •
edited by dshevtsov
Loading

Purpose of this pull request

This pull request (PR) adds new "Product layout" topic into front-end developer guide.

Affected DevDocs pages

Links to Magento source code

Thank you!

whatsnew
Added a new topic for Product layouts in the Frontend Developers Guide.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this May 11, 2019
@lorikrell lorikrell self-requested a review May 11, 2019 21:15
@lorikrell lorikrell added Contribution Day Issues and PRs for Contribution Days! Groomed and ready to work. New Topic A major update published as an entirely new document 2.x labels May 11, 2019
rogyar
rogyar suggested changes May 12, 2019
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, provide also links to the existing layout files from Magento Github repository (for all examples) in a separate comment to this PR.

Thank you!

guides/v2.1/frontend-dev-guide/layouts/product-layouts.md Outdated
Layout file | Description
--- | ---
`catalog_product_view.xml` | Common layout. Affects all product types
`catalog_product_view_type_bundle.xml` | Layout directives from this file implements to `bundle` product only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, change the "directive" term to the "layout" or "node". The directive term in development has a little bit different meaning and more applicable to an argument or a property.
So in result we have something like:

"Layout from this file is applied to bundle products only" and so on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, @rogyar !

Thank you!

fixed

@lorikrell lorikrell removed their request for review May 12, 2019 20:44
@atwixfirster
Copy link
Contributor Author

atwixfirster commented May 13, 2019 •
edited
Loading

Please, provide also links to the existing layout files from Magento Github repository (for all examples) in a separate comment to this PR.

Thank you!

Links to Magento source code

@rogyar rogyar added the Major Update Significant original updates to existing content label May 19, 2019
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@jeff-matthews jeff-matthews requested a review from lorikrell May 28, 2019 17:42
lorikrell
lorikrell approved these changes May 28, 2019
View reviewed changes
Copy link

@lorikrell lorikrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to the TOC and a slight edit. Looks good.

@lorikrell
Copy link

running tests

@lorikrell
Copy link

running tests

@lorikrell lorikrell merged commit 1c2c68d into magento:master May 28, 2019
@ghost
Copy link

ghost commented May 28, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@rogyar rogyar rogyar approved these changes

@lorikrell lorikrell lorikrell approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@rogyar rogyar

Labels
2.x Contribution Day Issues and PRs for Contribution Days! Groomed and ready to work. Major Update Significant original updates to existing content New Topic A major update published as an entirely new document Partner: Atwix partners-contribution PR created by Magento partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atwixfirster @devops-devdocs @lorikrell @rogyar @magento-engcom-team