Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

speedy008
Copy link
Contributor

@speedy008 speedy008 commented May 13, 2019

Purpose of this pull request

This pull request (PR) Consist of Brief detail of UI Component in frontend and Adminhtml area

Affected DevDocs pages

whatsnew
Added 'UI component used in the frontend design area' and 'UI component used in the Adminhtml area' to Overview of UI components.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@erikmarr erikmarr self-requested a review May 17, 2019 15:08
@erikmarr
Copy link
Contributor

Hi @speedy008 can you update your PR to include links to the Magento source code?

@rogyar rogyar self-assigned this May 19, 2019
@@ -70,7 +70,7 @@ UI component is a combination of:
2. **JavaScript** class inherited from one of the Magento JavaScript framework UI components base classes (such as [UIElement]({{ page.baseurl }}/ui_comp_guide/concepts/ui_comp_uielement_concept.html), [UIClass]({{ page.baseurl }}/ui_comp_guide/concepts/ui_comp_uiclass_concept.html) or [UICollection]({{ page.baseurl }}/ui_comp_guide/concepts/ui_comp_uicollection_concept.html)).


3. **Related template(s)**
3. **Related template(s)** using KnockoutJs bindings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove this clarification. The existing list is about "what", but not "how". So, let's keep it simple.
Thank you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogyar removed clarification. make it simple


* Configured through layout XML

* The jsLayout argument is used to specify information
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided information is very useful.
However, as a reader, I have doubts about what exact information can we specify using jsLayout.
If you could add an XML example for every case - it would be awesome.
Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the small example of xml layout file for Ui component of frontend area

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Please, adjust the other versions of the documentation as well. As far as I see, you've added the mentioned example only for 2.3.

Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added an example in 2.2 and 2.3 version as well

@rogyar rogyar added the Technical Updates to the code or processes that alter the technical content of the doc label May 20, 2019
@dobooth dobooth requested review from dobooth and removed request for erikmarr May 21, 2019 17:52
@dobooth dobooth added 2.1.x 2.2.x 2.3.x Magento 2.3 related changes labels May 21, 2019
@dobooth
Copy link
Contributor

dobooth commented May 21, 2019

running tests

@dobooth dobooth merged commit b4a39f7 into magento:master May 21, 2019
@ghost
Copy link

ghost commented May 21, 2019

Hi @speedy008, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Partner: Krish TechnoLabs partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants