Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

magento/devdocs#: Develop data and schema patches. Revert module datapatch #4504

Merged
merged 5 commits into from
May 13, 2019

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented May 13, 2019

Purpose of this pull request

This pull request (PR) adds information how to revert module's data patches.

Affected DevDocs pages

Links to Magento source code

whatsnew
Added "Reverting data patches" section to Develop data and schema patches.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@ronak2ram ronak2ram self-requested a review May 13, 2019 10:47
@ronak2ram ronak2ram self-assigned this May 13, 2019
@dobooth dobooth added Major Update Significant original updates to existing content 2.3.x Magento 2.3 related changes labels May 13, 2019
@erikmarr erikmarr self-requested a review May 13, 2019 19:10
@@ -120,6 +119,22 @@ The following code sample defines a data patch class that has a dependency.
}
```

## Reverting data patches

Magento does not allow the reverting of a particular module data patch. It only allows the reverting of all module data patches per the `module:uninstall` command.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Magento does not allow the reverting of a particular module data patch. It only allows the reverting of all module data patches per the `module:uninstall` command.
Magento does not allow you to revert a particular module data patch. However, you can revert all `composer` installed or `non-composer` installed data patches using the `module:uninstall` command.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


Magento does not allow the reverting of a particular module data patch. It only allows the reverting of all module data patches per the `module:uninstall` command.

Run the folowing command to revert all the module's data patches (only for modules that have been installed through `composer`):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Run the folowing command to revert all the module's data patches (only for modules that have been installed through `composer`):
Run the following command to revert all `composer` installed data patches:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

bin/magento module:uninstall Vendor_ModuleName
```

To revert all `non composer` data patches, run:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To revert all `non composer` data patches, run:
Run the following command to revert all `non-composer` installed data patches:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor Author

@atwixfirster atwixfirster May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikmarr , requested changes have been implemented. Could you please review?

Thank you!

@erikmarr
Copy link
Contributor

running tests

@erikmarr erikmarr merged commit 49776f5 into magento:master May 13, 2019
@ghost
Copy link

ghost commented May 13, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@erikmarr
Copy link
Contributor

Thanks @atwixfirster!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Atwix partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants