This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Added missing options and updated methods section for menu widget #4589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Atwix
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
ronak2ram
suggested changes
May 23, 2019
There was a problem hiding this comment.
Hi @vasilii-b
For file : guides/v2.2/javascript-dev-guide/widgets/widget_menu.md
Replace this at line no 6:- /guides/v2.0/frontend-dev-guide/javascript/widget_menu.html
Actually, redirect_from used when you want to redirect some URL to the current file URL.
|
Hi @ronak2ram , |
ronak2ram
approved these changes
May 23, 2019
jeff-matthews
added
Special achievement
jeff-matthews
suggested changes
May 24, 2019
|
Hi @jeff-matthews , |
jeff-matthews
approved these changes
May 24, 2019
|
running tests |
|
Hi @vasilii-b, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request (PR) aims to enrich the documentation for Menu Widget (#1276) with the following:
Affected DevDocs pages
Links to Magento source code
Magento 2.1
Magento 2.2
Magento 2.3
whatsnew
Added missing menu widget options and methods.