Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

abrarpathan19
Copy link
Contributor

@abrarpathan19 abrarpathan19 commented May 27, 2019

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

1 similar comment
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@ronak2ram ronak2ram self-requested a review May 27, 2019 09:23
@ronak2ram ronak2ram self-assigned this May 27, 2019
@ronak2ram
Copy link
Member

Hi @abrarpathan19
Thanks for your contribution.
We standardized all commands without php so we can't accept this.

@ronak2ram ronak2ram closed this May 28, 2019
@ghost
Copy link

ghost commented May 28, 2019

Hi @abrarpathan19, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@abrarpathan19
Copy link
Contributor Author

abrarpathan19 commented May 29, 2019

Hi @abrarpathan19
Thanks for your contribution.
We standardized all commands without php so we can't accept this.

Thanks for the update, Can you please review this link where the commands are already mentioned with php
https://devdocs.magento.com/guides/v2.3/cloud/howtos/install-components.html

Thank you !!!

image

@keharper
Copy link
Contributor

This comment in #4274 by @hguthrie explains why the php remains in this topic.

The blanket PHP changes made can not apply to Cloud documentation. Some of those affect sample code for copy to YAML files and will cause errors without the "PHP". Please revert changes to Cloud documentation for PHP command.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants