Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

irenelagno
Copy link
Contributor

@irenelagno irenelagno commented Jun 4, 2019

Purpose of this pull request

This pull request (PR) adding information about version policy for @api class update.

whatsnew
Added 'New optional method argument' to both PHP Interface and to PHP Class in Codebase Changes.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 4, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link

@irenelagno thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@dobooth dobooth self-assigned this Jun 4, 2019
@dobooth dobooth requested review from maghamed and buskamuza June 4, 2019 19:46
@dobooth dobooth added 2.1.x 2.2.x 2.3.x Magento 2.3 related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Internal Dev Differentiates work between community and Magento staff labels Jun 4, 2019
@YevSent
Copy link
Contributor

YevSent commented Jun 12, 2019

@irenelagno, please, add the same rule for @api interfaces.

@irenelagno
Copy link
Contributor Author

@joni-jones , added

@dshevtsov dshevtsov requested review from paliarush and YevSent June 13, 2019 14:34
@dobooth dobooth added Major Update Significant original updates to existing content and removed Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies labels Jun 24, 2019
@dobooth
Copy link
Contributor

dobooth commented Jun 25, 2019

running tests

@dobooth dobooth merged commit 16a741e into magento:master Jun 25, 2019
@ghost
Copy link

ghost commented Jun 25, 2019

Hi @irenelagno, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants