Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

tomreece
Copy link
Contributor

@tomreece tomreece commented Jun 4, 2019

In this pull request I add a new section to the Technical Guidelines specifically for Functional Testing with MFTF. I am opening the PR to gather feedback from many people before we merge it.
https://devdocs.magento.com/guides/v2.3/coding-standards/technical-guidelines.html

whatsnew
Added the '11.3. Functional Testing' section to Technical Guidelines.

@magento-engcom-team
Copy link

@tomreece thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@tomreece tomreece changed the title MQE-1482: Add MFTF Tests technical guidelines to "Technical Guidelines" topic on DevDocs [WIP] MQE-1482: Add MFTF Tests technical guidelines to "Technical Guidelines" topic on DevDocs Jun 4, 2019
@dobooth dobooth self-assigned this Jun 4, 2019
@dobooth dobooth requested review from maghamed and okolesnyk June 4, 2019 20:29
@dobooth dobooth added Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content 2.3.x Magento 2.3 related changes labels Jun 4, 2019
tomreece added 3 commits June 5, 2019 11:38
…s" topic on DevDocs

- Added content from MFTF devdocs Best Practices page
…s" topic on DevDocs

- Copy over content from MFTF devdocs Tips and Tricks page
…s" topic on DevDocs

- Style tweaks
- Reordered sections for better flow, less jumping around of topics
…s" topic on DevDocs

- Made review feedback changes
Copy link
Contributor

@ivy00johns ivy00johns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of comments added. Please let me know if you have any questions or if we need to debate certain rules with the Team.

Copy link
Member

@okolesnyk okolesnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with most of Johns and Ji comments.
I also think we should schedule a meeting to talk about it more.

…s" topic on DevDocs

- Deliver only Pages and Sections topics that we went through as a team
@tomreece
Copy link
Contributor Author

In my latest commit I deliver the Pages and Sections topics that we went through as a team and agree with.

This is ready to merge. Other topics will be delivered in the near future.

@tomreece tomreece changed the title [WIP] MQE-1482: Add MFTF Tests technical guidelines to "Technical Guidelines" topic on DevDocs MQE-1482: Add MFTF Tests technical guidelines to "Technical Guidelines" topic on DevDocs Jun 18, 2019
@tomreece
Copy link
Contributor Author

Hi @maghamed -- will you review this?

@okolesnyk
Copy link
Member

@tomreece You've added items to Magento 2.2 documentation please also add it to Magento 2.3 docs.

@tomreece
Copy link
Contributor Author

@okolesnyk the 2.3 document pulls from the 2.2 document. See https://github.com/magento/devdocs/blob/master/guides/v2.3/coding-standards/technical-guidelines.md

I don't understand what I'm supposed to do.

@tomreece
Copy link
Contributor Author

I spoke with @okolesnyk and we are good.

@dobooth What should I do in order to get this merged?

@dobooth
Copy link
Contributor

dobooth commented Jun 26, 2019

running tests

@dobooth
Copy link
Contributor

dobooth commented Jun 26, 2019

running tests

@dshevtsov
Copy link
Collaborator

@dobooth please add whatsnew

@dobooth dobooth merged commit 8de1ed6 into magento:master Jun 26, 2019
@ghost
Copy link

ghost commented Jun 26, 2019

Hi @tomreece, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants