-
Notifications
You must be signed in to change notification settings - Fork 1.7k
MQE-1482: Add MFTF Tests technical guidelines to "Technical Guidelines" topic on DevDocs #4677
Conversation
…s" topic on DevDocs
An admin must run tests on this PR before it can be merged. |
…s" topic on DevDocs - Added content from MFTF devdocs Best Practices page
…s" topic on DevDocs - Copy over content from MFTF devdocs Tips and Tricks page
…s" topic on DevDocs - Style tweaks - Reordered sections for better flow, less jumping around of topics
…s" topic on DevDocs - Made review feedback changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of comments added. Please let me know if you have any questions or if we need to debate certain rules with the Team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with most of Johns and Ji comments.
I also think we should schedule a meeting to talk about it more.
…s" topic on DevDocs - Deliver only Pages and Sections topics that we went through as a team
In my latest commit I deliver the This is ready to merge. Other topics will be delivered in the near future. |
Hi @maghamed -- will you review this? |
@tomreece You've added items to Magento 2.2 documentation please also add it to Magento 2.3 docs. |
@okolesnyk the 2.3 document pulls from the 2.2 document. See https://github.com/magento/devdocs/blob/master/guides/v2.3/coding-standards/technical-guidelines.md I don't understand what I'm supposed to do. |
I spoke with @okolesnyk and we are good. @dobooth What should I do in order to get this merged? |
running tests |
running tests |
@dobooth please add |
Hi @tomreece, thank you for your contribution! |
In this pull request I add a new section to the Technical Guidelines specifically for Functional Testing with MFTF. I am opening the PR to gather feedback from many people before we merge it.
https://devdocs.magento.com/guides/v2.3/coding-standards/technical-guidelines.html
whatsnew
Added the '11.3. Functional Testing' section to Technical Guidelines.