Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Ken 3566 update asc install #4704

Merged
merged 6 commits into from
Jun 7, 2019
Merged

Ken 3566 update asc install #4704

merged 6 commits into from
Jun 7, 2019

Conversation

hickskenh
Copy link
Contributor

Purpose of this pull request

This pull request (PR) updates the Install instructions for Amazon Sales Channel extension. This change includes composer-specific update and a link to API key info. This was a request from Product.

Affected DevDocs pages

https://devdocs.magento.com/extensions/amazon-sales/

whatsnew
Updated Amazon Sales Channel installation information with composer-specific step.

@hickskenh hickskenh requested a review from lorikrell June 7, 2019 16:21
- Navigate to your Magento project directory and update your composer.json file.

```bash
composer require magento/services-connector:~1.0.3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? Shouldn't it be magento/amazon-sales-channel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently there is an issue with the service connector. the engineer gave this info
composer update – will update all components including their dependencies
composer require magento/services-connector:~1.0.3 – will install connector only

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instructions are for installing the extension though. So would they need to update their composer for magento/amazon-sales-channel and magento/services-connector:~1.0.3 then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if they don't do this, they are having service connector errors. i am unfamiliar with the install process. when i asked if we needed to update the cli installation, i was told "they aren't installing it that way. we just need to add this step".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can add to the step language, update the composer for service connector.

Copy link

@lorikrell lorikrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Ken!

@hickskenh
Copy link
Contributor Author

running tests

@hickskenh hickskenh merged commit e2f4c50 into master Jun 7, 2019
@ghost
Copy link

ghost commented Jun 7, 2019

Hi @hickskenh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@hickskenh hickskenh deleted the ken-3566-update-asc-install branch June 7, 2019 20:05
@hickskenh hickskenh added Technical Updates to the code or processes that alter the technical content of the doc Major Update Significant original updates to existing content and removed Technical Updates to the code or processes that alter the technical content of the doc labels Jun 7, 2019
@dshevtsov
Copy link
Collaborator

@hickskenh please specify a version using labels at this PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants