Added info about PasswordStrengthIndicator widget #4733

VitaliyBoyko · 2019-06-12T13:11:56Z

Purpose of this pull request

This pull request (PR) adds the PasswordStrengthIndicator widget documentation.

Affected DevDocs pages

Links to Magento source code

whatsnew
Added information about the PasswordStrengthIndicator widget.

devops-devdocs · 2019-06-12T13:13:08Z

An admin must run tests on this PR before it can be merged.

guides/v2.1/javascript-dev-guide/widgets/widget_password_strength_indicator.md

rogyar · 2019-06-12T15:16:41Z

Hi @VitaliyBoyko. Thank you for your collaboration. Please, adjust the changes according to the review comments for both versions. Thank you

VitaliyBoyko · 2019-06-17T15:04:24Z

Hi @rogyar
I've updated the PR according to your suggestions. Thank you for the review!

erikmarr

@VitaliyBoyko this looks really good! Just some editorial feedback.

erikmarr · 2019-06-18T18:05:07Z

guides/v2.1/javascript-dev-guide/widgets/widget_password_strength_indicator.md

+
+## Overview {#password_strength_indicator_overview}
+
+Magento password strength indicator {% glossarytooltip f0dcf847-ce21-4b88-8b45-83e1cbf08100 %}widget{% endglossarytooltip %} show the user immediate feedback on the validity and strength of a password while it is being typed.


Suggested change

Magento password strength indicator {% glossarytooltip f0dcf847-ce21-4b88-8b45-83e1cbf08100 %}widget{% endglossarytooltip %} show the user immediate feedback on the validity and strength of a password while it is being typed.

The Magento password strength indicator {% glossarytooltip f0dcf847-ce21-4b88-8b45-83e1cbf08100 %}widget{% endglossarytooltip %} provides immediate feedback on the validity and strength of a password while it is being typed.

erikmarr · 2019-06-18T18:06:16Z

guides/v2.1/javascript-dev-guide/widgets/widget_password_strength_indicator.md

+## Overview {#password_strength_indicator_overview}
+
+Magento password strength indicator {% glossarytooltip f0dcf847-ce21-4b88-8b45-83e1cbf08100 %}widget{% endglossarytooltip %} show the user immediate feedback on the validity and strength of a password while it is being typed.
+If the password is not strong enough the UI asks the user to choose a new password.


Suggested change

If the password is not strong enough the UI asks the user to choose a new password.

If the password is not strong enough, Magento prompts the user to choose a new password.

erikmarr · 2019-06-18T18:23:09Z

guides/v2.2/javascript-dev-guide/widgets/widget_password_strength_indicator.md

+
+## Events {#password_strength_indicator_events}
+
+The password strength indicator widget listens `change`, `keyup` and `paste` events on the password and the email inputs. Listening to the email input is optional.


Suggested change

The password strength indicator widget listens `change`, `keyup` and `paste` events on the password and the email inputs. Listening to the email input is optional.

The password strength indicator widget listens for `change`, `keyup` and `paste` events on the password and the email inputs. Listening to the email input is optional.

erikmarr · 2019-06-18T18:27:58Z

guides/v2.1/javascript-dev-guide/widgets/widget_password_strength_indicator.md

+});
+```
+
+For details about how to initialize the widget in a`.phtml` template, refer to the [JavaScript initialization] topic.


Please add the link to the topic: https://devdocs.magento.com/guides/v2.1/javascript-dev-guide/javascript/js_init.html

erikmarr · 2019-06-18T18:28:34Z

guides/v2.1/javascript-dev-guide/widgets/widget_password_strength_indicator.md

+
+## Events {#password_strength_indicator_events}
+
+The password strength indicator widget listens `change`, `keyup` and `paste` events on the password input.


Suggested change

The password strength indicator widget listens `change`, `keyup` and `paste` events on the password input.

The password strength indicator widget listens for `change`, `keyup`, and `paste` events on the password input.

erikmarr · 2019-06-18T18:31:31Z

guides/v2.2/javascript-dev-guide/widgets/widget_password_strength_indicator.md

+});
+```
+
+For details about how to initialize the widget in a`.phtml` template, refer to the [JavaScript initialization] topic.


Please add the link to the topic: https://devdocs.magento.com/guides/v2.1/javascript-dev-guide/javascript/js_init.html

erikmarr · 2019-06-18T18:32:24Z

guides/v2.2/javascript-dev-guide/widgets/widget_password_strength_indicator.md

+
+## Overview {#password_strength_indicator_overview}
+
+Magento password strength indicator {% glossarytooltip f0dcf847-ce21-4b88-8b45-83e1cbf08100 %}widget{% endglossarytooltip %} show the user immediate feedback on the validity and strength of a password while it is being typed.


The Magento password strength indicator {% glossarytooltip f0dcf847-ce21-4b88-8b45-83e1cbf08100 %}widget{% endglossarytooltip %} provides immediate feedback on the validity and strength of a password while it is being typed.

erikmarr · 2019-06-18T18:32:50Z

guides/v2.2/javascript-dev-guide/widgets/widget_password_strength_indicator.md

+## Overview {#password_strength_indicator_overview}
+
+Magento password strength indicator {% glossarytooltip f0dcf847-ce21-4b88-8b45-83e1cbf08100 %}widget{% endglossarytooltip %} show the user immediate feedback on the validity and strength of a password while it is being typed.
+If the password is not strong enough the UI asks the user to choose a new password.


Suggested change

If the password is not strong enough the UI asks the user to choose a new password.

If the password is not strong enough, Magento prompts the user to choose a new password.

erikmarr · 2019-06-18T18:34:33Z

guides/v2.1/javascript-dev-guide/widgets/widget_password_strength_indicator.md

+
+### Result
+
+The result is a user aware of typed password strength and prevented from using weak one.


Suggested change

The result is a user aware of typed password strength and prevented from using weak one.

The result is an indication of the strength of the user's password.

guides/v2.2/javascript-dev-guide/widgets/widget_password_strength_indicator.md

dobooth · 2019-07-08T19:59:26Z

Hi @VitaliyBoyko Thanks for the PR. In the time between your submitting this PR and now, we stopped supporting v2.1. Therefore, we can't accept any changes to that version. If you update your branch and remove the 2.1 file from this PR and keep the changes in 2.2 and 2.3, we can merge it.

erikmarr · 2019-07-18T15:51:40Z

guides/v2.1/javascript-dev-guide/widgets/jquery-widgets-about.md

@@ -21,6 +21,7 @@ This guide discusses the following widgets:
 -   [Menu widget]
 -   [Modal widget]
 -   [Navigation widget]
+-   [PasswordStrengthIndicator widget]


Please remove changes to the 2.1 version. You should make these in the 2.2 version.

…ator widget to the main menu

Fixed typo

erikmarr

Looks good @VitaliyBoyko!

erikmarr · 2019-07-19T13:46:00Z

running tests

erikmarr · 2019-07-19T14:16:26Z

Hi @VitaliyBoyko I think we should add an entry to the 2.2 version of the widgets topic, but wanted to confirm with you:
https://devdocs.magento.com/guides/v2.2/javascript-dev-guide/widgets/jquery-widgets-about.html

VitaliyBoyko · 2019-07-19T14:31:33Z

Hi @erikmarr
Yes. I have totally forgotten that the 2.2 version is symlinked.

And it seems like I had an outdated branch.

This reverts commit b91bf97

…Boyko/devdocs into PasswordStrengthIndicator-widget

erikmarr · 2019-07-19T14:57:16Z

Hi @VitaliyBoyko thanks for all your help with this topic! We need one more change before I can get this merged in. Can you create a symlink for the guides/v2.3 version to your new v2.2 topic:
https://devdocs.magento.com/guides/v2.2/javascript-dev-guide/widgets/widget_password_strength_indicator.html
We had some issues because our link checker is expecting that 2.3 topic to exist but we don't have a symlink.

erikmarr · 2019-07-19T15:46:11Z

running tests

guides/v2.3/javascript-dev-guide/widgets/widget_password_strength_indicator.md

erikmarr · 2019-07-19T21:20:12Z

running tests

erikmarr · 2019-07-19T21:21:00Z

running tests

erikmarr · 2019-07-22T15:30:41Z

Hi @VitaliyBoyko there's something wrong with the symlink. Can you run these commands:
unlink guides/v2.3/javascript-dev-guide/widgets/widget_password_strength_indicator.md
then
ln -s ../../../../guides/v2.2/javascript-dev-guide/widgets/widget_password_strength_indicator.md guides/v2.3/javascript-dev-guide/widgets/widget_password_strength_indicator.md

Sorry for all the back and forth on this PR! We appreciate your help.

erikmarr · 2019-07-22T18:18:20Z

tested locally and this change looks good! Will run tests and merge.

erikmarr · 2019-07-22T18:22:49Z

running tests

ghost · 2019-07-22T18:38:20Z

Hi @VitaliyBoyko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

erikmarr · 2019-07-22T18:38:43Z

Thanks @VitaliyBoyko!

Vitaliy Boyko added 2 commits June 12, 2019 15:55

Added info about PasswordStrengthIndicator widget

aff73e3

Updated info for v2.1 v2.2

4b1a1e8

magento-engcom-team added Partner: Atwix partners-contribution PR created by Magento partner labels Jun 12, 2019

rogyar self-assigned this Jun 12, 2019

rogyar suggested changes Jun 12, 2019

View reviewed changes

rogyar added Waiting for Response Waiting for response from internal/external parties 2.1.x 2.2.x 2.3.x Magento 2.3 related changes New Topic A major update published as an entirely new document labels Jun 12, 2019

jeff-matthews added this to Backlog in Processing PRs via automation Jun 16, 2019

erikmarr self-assigned this Jun 17, 2019

Fixes after review

1613084

erikmarr requested changes Jun 18, 2019

View reviewed changes

Processing PRs automation moved this from Backlog to Needs writer approval Jun 18, 2019

Removed 2.1 support and added the requested changes

b69bb6d

erikmarr approved these changes Jul 18, 2019

View reviewed changes

erikmarr requested changes Jul 18, 2019

View reviewed changes

Vitaliy Boyko added 2 commits July 19, 2019 15:20

Fixed jquery-widgets-about.md 2.1 and added the PasswordStrengthIndic…

15ae09d

…ator widget to the main menu

Update javascript-developer-guide.yml

33f5e35

Fixed typo

rogyar approved these changes Jul 19, 2019

View reviewed changes

Processing PRs automation moved this from Needs writer approval to Needs Jenkins testing Jul 19, 2019

erikmarr approved these changes Jul 19, 2019

View reviewed changes

Merge branch 'master' into PasswordStrengthIndicator-widget

b5bcc3f

Created separate jquery widgets about for 2.2

b91bf97

Vitaliy Boyko added 3 commits July 19, 2019 17:32

Revert "Created separate jquery widgets about for 2.2"

37f6e6a

This reverts commit b91bf97

Merge branch 'PasswordStrengthIndicator-widget' of github.com:Vitaliy…

c17e63d

…Boyko/devdocs into PasswordStrengthIndicator-widget

Added PasswordStrengthIndicator to widgets about page

1b96ce7

Added PasswordStrengthIndicator symlink for 2.3 version

0e742b2

Merge branch 'master' into PasswordStrengthIndicator-widget

f054775

erikmarr requested changes Jul 19, 2019

View reviewed changes

guides/v2.3/javascript-dev-guide/widgets/widget_password_strength_indicator.md Outdated Show resolved Hide resolved

Processing PRs automation moved this from Needs Jenkins testing to Needs writer approval Jul 19, 2019

Vitaliy and others added 2 commits July 20, 2019 00:11

Update widget_password_strength_indicator.md

83ea4f8

Merge branch 'master' into PasswordStrengthIndicator-widget

ff4eb59

erikmarr approved these changes Jul 19, 2019

View reviewed changes

Processing PRs automation moved this from Needs writer approval to Needs Jenkins testing Jul 19, 2019

erikmarr and others added 2 commits July 22, 2019 10:32

Merge branch 'master' into PasswordStrengthIndicator-widget

37df614

Fixed symlink

28acc47

Merge branch 'master' into PasswordStrengthIndicator-widget

086db9f

erikmarr merged commit a595258 into magento:master Jul 22, 2019

Processing PRs automation moved this from Needs Jenkins testing to Done Jul 22, 2019

erikmarr removed 2.1.x Waiting for Response Waiting for response from internal/external parties labels Jul 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added info about PasswordStrengthIndicator widget #4733

Added info about PasswordStrengthIndicator widget #4733

VitaliyBoyko commented Jun 12, 2019 •

edited by erikmarr

devops-devdocs commented Jun 12, 2019

rogyar commented Jun 12, 2019

VitaliyBoyko commented Jun 17, 2019

erikmarr left a comment

erikmarr Jun 18, 2019

erikmarr Jun 18, 2019

erikmarr Jun 18, 2019

erikmarr Jun 18, 2019

erikmarr Jun 18, 2019

erikmarr Jun 18, 2019

erikmarr Jun 18, 2019

erikmarr Jun 18, 2019

erikmarr Jun 18, 2019

dobooth commented Jul 8, 2019

erikmarr Jul 18, 2019

erikmarr left a comment

erikmarr commented Jul 19, 2019

erikmarr commented Jul 19, 2019

VitaliyBoyko commented Jul 19, 2019 •

edited

erikmarr commented Jul 19, 2019

erikmarr commented Jul 19, 2019

erikmarr commented Jul 19, 2019

erikmarr commented Jul 19, 2019

erikmarr commented Jul 22, 2019

erikmarr commented Jul 22, 2019

erikmarr commented Jul 22, 2019

ghost commented Jul 22, 2019

erikmarr commented Jul 22, 2019


		## Overview {#password_strength_indicator_overview}

		Magento password strength indicator {% glossarytooltip f0dcf847-ce21-4b88-8b45-83e1cbf08100 %}widget{% endglossarytooltip %} show the user immediate feedback on the validity and strength of a password while it is being typed.

	If the password is not strong enough the UI asks the user to choose a new password.
	If the password is not strong enough, Magento prompts the user to choose a new password.


		## Events {#password_strength_indicator_events}

		The password strength indicator widget listens `change`, `keyup` and `paste` events on the password and the email inputs. Listening to the email input is optional.


		### Result

		The result is a user aware of typed password strength and prevented from using weak one.

	The result is a user aware of typed password strength and prevented from using weak one.
	The result is an indication of the strength of the user's password.

Added info about PasswordStrengthIndicator widget #4733

Added info about PasswordStrengthIndicator widget #4733

Conversation

VitaliyBoyko commented Jun 12, 2019 • edited by erikmarr

Purpose of this pull request

Affected DevDocs pages

Links to Magento source code

devops-devdocs commented Jun 12, 2019

rogyar commented Jun 12, 2019

VitaliyBoyko commented Jun 17, 2019

erikmarr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dobooth commented Jul 8, 2019

Choose a reason for hiding this comment

erikmarr left a comment

Choose a reason for hiding this comment

erikmarr commented Jul 19, 2019

erikmarr commented Jul 19, 2019

VitaliyBoyko commented Jul 19, 2019 • edited

erikmarr commented Jul 19, 2019

erikmarr commented Jul 19, 2019

erikmarr commented Jul 19, 2019

erikmarr commented Jul 19, 2019

erikmarr commented Jul 22, 2019

erikmarr commented Jul 22, 2019

erikmarr commented Jul 22, 2019

ghost commented Jul 22, 2019

erikmarr commented Jul 22, 2019

VitaliyBoyko commented Jun 12, 2019 •

edited by erikmarr

VitaliyBoyko commented Jul 19, 2019 •

edited