Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

hguthrie
Copy link
Contributor

@hguthrie hguthrie commented Jun 25, 2019

This pull request adds a new topic to the Cloud documentation: Functional testing in Docker.
Preview: https://devdocs.magedevteam.com/581/guides/v2.2/cloud/docker/docker-development-testing.html
This PR is in draft because I need more information. Do not give an editorial review yet. There is content missing and content in strange places.

@hguthrie hguthrie self-assigned this Jun 25, 2019
@hguthrie hguthrie added In progress Internal Dev Differentiates work between community and Magento staff labels Jun 25, 2019
@hguthrie hguthrie requested a review from BaDos June 25, 2019 13:53
@hguthrie hguthrie force-pushed the hg-mc3684-ece-test branch from b77d132 to bf21160 Compare June 25, 2019 17:01
@hguthrie hguthrie marked this pull request as ready for review June 25, 2019 17:03
@hguthrie hguthrie requested a review from meker12 June 25, 2019 20:01
Copy link
Contributor

@meker12 meker12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions on the new Docker functional tests topic

- `443`—web, tls
- `3306`—apache, mysql

1. Switch to the preferred PHP version for running tests.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be helpful to provide hint here --Consider providing link to Versions, or provide example command

hguthrie and others added 2 commits June 25, 2019 16:01
Co-Authored-By: Margaret Eker <meker@adobe.com>
@hguthrie hguthrie added 2.x New Topic A major update published as an entirely new document and removed In progress labels Jun 25, 2019
@hguthrie hguthrie merged commit 0039c4b into Cloud-2002.0.20 Jun 25, 2019
@ghost
Copy link

ghost commented Jun 25, 2019

Hi @hguthrie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@hguthrie hguthrie deleted the hg-mc3684-ece-test branch June 25, 2019 21:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Internal Dev Differentiates work between community and Magento staff New Topic A major update published as an entirely new document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants