This repository was archived by the owner on Nov 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
MAGECLOUD-3684 functional testing in Docker #4828
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b77d132
to
bf21160
Compare
meker12
approved these changes
Jun 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions on the new Docker functional tests topic
- `443`—web, tls | ||
- `3306`—apache, mysql | ||
|
||
1. Switch to the preferred PHP version for running tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be helpful to provide hint here --Consider providing link to Versions, or provide example command
Co-Authored-By: Margaret Eker <meker@adobe.com>
Hi @hguthrie, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
2.x
Internal Dev
Differentiates work between community and Magento staff
New Topic
A major update published as an entirely new document
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new topic to the Cloud documentation: Functional testing in Docker.
Preview: https://devdocs.magedevteam.com/581/guides/v2.2/cloud/docker/docker-development-testing.html
This PR is in draft because I need more information. Do not give an editorial review yet. There is content missing and content in strange places.