Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Updates for Google Shopping ads Channel v3.0 #4849

Merged
merged 16 commits into from
Jul 10, 2019

Conversation

hickskenh
Copy link
Contributor

@hickskenh hickskenh commented Jun 26, 2019

Purpose of this pull request

This pull request (PR) updates the Release Notes and install guide for Google Shopping Channel for v3.0, which includes the new Enable Log Service option. Updated the screen shot and added a note about enabling logging service.

Affected DevDocs pages

https://devdocs.magento.com/extensions/google-shopping-ads/
https://devdocs.magento.com/extensions/google-shopping-ads/release-notes/

whatsnew
Updated the Google Shopping ads Install documentation and Release Notes for version 3.0.

@hickskenh hickskenh added Major Update Significant original updates to existing content Google Shopping ads 2.0 labels Jun 26, 2019
Copy link

@lorikrell lorikrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken link and slight format question. - ignore PR not merged for merchdocs yet.

@lorikrell
Copy link

Also update the whatsnew with a link to the devdocs update file. Like:
Updated [Google Shopping ads Install](link) for version 2.0 to include the Enable Service Logs option.

Copy link

@lorikrell lorikrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. One bit of feedback to consider.

@hickskenh hickskenh changed the title Ken chan 3554 update install guide to include logging option Update installation guide for Google Shopping ads Channel extension Jun 26, 2019
@keharper keharper added the Internal Dev Differentiates work between community and Magento staff label Jun 27, 2019
@hickskenh
Copy link
Contributor Author

running tests

@hickskenh hickskenh changed the title Update installation guide for Google Shopping ads Channel extension Updates for Google Shopping ads Channel v3.0 Jul 9, 2019
@hickskenh hickskenh requested a review from jeff-matthews July 9, 2019 15:54
hickskenh and others added 2 commits July 9, 2019 11:05
Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
@hickskenh hickskenh requested a review from jeff-matthews July 9, 2019 16:07
@hickskenh
Copy link
Contributor Author

running tests

@hickskenh hickskenh merged commit 1b8c207 into master Jul 10, 2019
@ghost
Copy link

ghost commented Jul 10, 2019

Hi @hickskenh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@hickskenh hickskenh deleted the ken-chan-3554-update-for-google-logging branch July 10, 2019 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants