Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Updated Release Notes for Google Shopping ads Channel extension for version 2.0.1 #4850

Merged
merged 17 commits into from
Jun 28, 2019

Conversation

hickskenh
Copy link
Contributor

@hickskenh hickskenh commented Jun 26, 2019

Purpose of this pull request

This pull request (PR) updates the Release Notes for Google Shopping ads Channel extension for the 2.0.0 release. Also updated the Upcoming Release page and the compatibility table to include version 2.0.0 for Google Shopping ads.

Affected DevDocs pages

https://devdocs.magento.com/extensions/google-shopping-ads/release-notes/
https://devdocs.magento.com/release/

whatsnew
Release Notes for the Google Shopping ads Channel extension have been updated to include version 2.0.0. The Upcoming Releases page has also been updated.

@hickskenh hickskenh added Major Update Significant original updates to existing content Google Shopping ads 2.0 labels Jun 26, 2019
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to moving the new feature to the top of the list, I noticed some inconsistent use of terminal punctuation (periods). That may be intended, but it looks weird.

Also, shouldn't we update the release page with the new version?

https://devdocs.magento.com/release/

@hickskenh hickskenh changed the title Ken chan 3511 rel notes 2.0 Updated Release Notes for Google Shopping ads Channel extension for version 2.0.0 Jun 26, 2019
- changed release notes order
- updated GSaC version number on the release page and added 2.0.0 section in the compatibility.yml.
- added "CHAN-" for commented out ticket numbers in release notes
Copy link

@lorikrell lorikrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one other comment that caught my eye.

@keharper keharper added the Internal Dev Differentiates work between community and Magento staff label Jun 27, 2019
cahnged 2.0 content, added 2.0.1 fix for 2.0.0 install error
release/index.md Outdated
@@ -17,7 +17,7 @@ The following table describes the status of Magento software availability and wh
| **Magento Shipping** | Available now | Merchants on Magento 2.2.2+ can use the [onboarding process](https://account.magento.com/shipping/onboarding/start) |
| **Page Builder** | Available now | Bundled with {{site.data.var.ee}} 2.3.x |
| **Amazon Sales Channel 2.0.0** | Available now for {{site.data.var.ece}} 2.2.4+ and 2.3.x (US, Canada, Mexico)<br><br>EMEA and APAC availability expected in second half of 2019 | Magento Marketplace |
| **Google Shopping ads Channel 1.1.2** | Available now for {{site.data.var.ece}} 2.2.4+ and 2.3.x | [Magento Marketplace](http://marketplace.magento.com/magento-google-shopping-ads.html) |
| **Google Shopping ads Channel 2.0.0** | Available now for {{site.data.var.ece}} 2.2.4+ and 2.3.x | [Magento Marketplace](http://marketplace.magento.com/magento-google-shopping-ads.html) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 2.0.1?

Updated 2.0.0 to 2.0.1 and added 2.0.1 to the compatibilty table.
@hickskenh
Copy link
Contributor Author

running tests

@hickskenh hickskenh changed the title Updated Release Notes for Google Shopping ads Channel extension for version 2.0.0 Updated Release Notes for Google Shopping ads Channel extension for version 2.0.1 Jun 28, 2019
@hickskenh hickskenh merged commit a2f95b3 into master Jun 28, 2019
@ghost
Copy link

ghost commented Jun 28, 2019

Hi @hickskenh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@hickskenh hickskenh deleted the ken-chan-3511-rel-notes-1.2.0 branch June 28, 2019 04:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants