Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Add Code Sample example for calendar widget #4851

Merged
merged 6 commits into from
Jul 9, 2019

Conversation

ParthBrahmbhatt
Copy link
Contributor

@ParthBrahmbhatt ParthBrahmbhatt commented Jun 26, 2019

Purpose of this pull request

This PR is an improvement of Calendar widget, which provide an example of how the calendar can be used during initialization.

Affected DevDocs pages

whatsnew
Added a 'Code sample' section to Calendar Widget.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@ronak2ram ronak2ram self-requested a review June 27, 2019 05:45
@ronak2ram ronak2ram self-assigned this Jun 27, 2019
@dobooth dobooth added 2.1.x 2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content labels Jun 27, 2019
@ParthBrahmbhatt
Copy link
Contributor Author

Hello @dobooth ,
Let me know if anything is missing into above PR from my end.

@dobooth
Copy link
Contributor

dobooth commented Jul 9, 2019

Thanks @ParthBrahmbhatt. Since we stopped supported v2.1 a few day ago, we need to remove the v2.1 file and fix the merge conflict with v2.2 and we can get this in.

@ParthBrahmbhatt
Copy link
Contributor Author

Hello @dobooth
Thanks for the support and help for resolve this conflict.

@dobooth dobooth removed the 2.1.x label Jul 9, 2019
@dobooth
Copy link
Contributor

dobooth commented Jul 9, 2019

running tests

@dobooth dobooth merged commit 7696bda into magento:master Jul 9, 2019
@ghost
Copy link

ghost commented Jul 9, 2019

Hi @ParthBrahmbhatt, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Krish TechnoLabs partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants