Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

[DOCS] Added reference to Extend Config Data for the Store GraphQl … #4883

Merged
merged 7 commits into from
Jul 18, 2019

Conversation

lewisvoncken
Copy link
Contributor

@lewisvoncken lewisvoncken commented Jul 2, 2019

…endpoint

Purpose of this pull request

This pull request (PR) adds a reference to add your own configuration to the Store GraphQl endpoint by using the extendConfigData array within the construct of the StoreConfigDataProvider

Added the following content:
image

Affected DevDocs pages

Links to Magento source code

Mage2gen example module

whatsnew
Described how to add custom store configuration attributes to the storeConfig query.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@ronak2ram ronak2ram self-assigned this Jul 9, 2019
@ronak2ram ronak2ram self-requested a review July 9, 2019 05:35
Copy link
Member

@ronak2ram ronak2ram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lewisvoncken
Thanks for your contribution.
Can you please update suggested changes.

@lewisvoncken lewisvoncken force-pushed the experius-patch-extend-config-data branch from b5bbe65 to 488e482 Compare July 9, 2019 07:39
@lewisvoncken
Copy link
Contributor Author

@ronak2ram I have just updated according to the suggested change.

@jeff-matthews jeff-matthews requested a review from keharper July 11, 2019 14:30
@jeff-matthews jeff-matthews added 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content labels Jul 11, 2019
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some great information. I'd like to expand it a bit and create a new topic. It could have a title like "Extend a query or mutation with custom attributes" and be placed in the graphql/develop directory. The topic could have the following contents:

  1. An introductory paragraph or two that describes the task.
  2. A section that describes the custom fields.
  3. A section about updating the di.xml file.
  4. A section about the custom module's schema.graphqls file.
  5. An example query containing the custom attribute and results.

3 & 4 are mostly done, and 5 would be easy. I don't know how much work it would take to describe what you had to do to create these custom fields.

As with any new topic contributed by the community, your company would get full credit for the topic.

Let me know whether you'd be willing to do this.

Meanwhile, I've also posted some editorial corrections.

lewisvoncken and others added 4 commits July 11, 2019 20:48
Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
@lewisvoncken
Copy link
Contributor Author

lewisvoncken commented Jul 11, 2019

@keharper The requested changes have been applied and I am willing to do this but in my opinion it should be separated from this pr so I will make a new one soon.

@keharper
Copy link
Contributor

@lewisvoncken One more small change.

Co-Authored-By: Kevin Harper <keharper@users.noreply.github.com>
@lewisvoncken
Copy link
Contributor Author

@keharper
The small changes has been applied

@keharper
Copy link
Contributor

running tests

@keharper keharper merged commit 273ce92 into magento:master Jul 18, 2019
@ghost
Copy link

ghost commented Jul 18, 2019

Hi @lewisvoncken, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper
Copy link
Contributor

Thanks for your contribution, @lewisvoncken .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Experius partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants