Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

dshevtsov
Copy link
Collaborator

Purpose of this pull request

This pull request updates the What's New page since last update on June 27.

Affected DevDocs pages

@dshevtsov dshevtsov added the Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies label Jul 8, 2019
@dshevtsov dshevtsov requested a review from meker12 July 8, 2019 16:05
@dshevtsov dshevtsov self-assigned this Jul 8, 2019
@dshevtsov dshevtsov requested a review from shrielenee July 8, 2019 16:06
type: Major update
date: June 28, 2019
link: https://github.com/magento/devdocs/pull/4850
- description: "- Documented the `{all}` route template option for the `routes.yaml`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this description enclosed in " "? In the PR, it's two bulleted items.

Copy link
Collaborator Author

@dshevtsov dshevtsov Jul 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The double quotes are added by the YAML formatter automatically. I assume that this is done because the string starts with - and hyphen is a special symbol in YAML that indicates an array.

Copy link
Contributor

@meker12 meker12 Jul 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so looking at a previous What's New entry that includes a list: #4839 -- looks like I need to add an opening sentence?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is up to your choice. We do not have such requirement.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK -- I updated it so the items would be in a list. Thanks.

type: Major update
date: July 8, 2019
link: https://github.com/magento/devdocs/pull/4630
- description: Clarified the Functional testing for Docker is for ece-tools and not
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heather is updating description to include link.

@dshevtsov
Copy link
Collaborator Author

running tests

@dshevtsov dshevtsov merged commit 4c9fe10 into master Jul 8, 2019
@ghost
Copy link

ghost commented Jul 8, 2019

Hi @dshevtsov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@dshevtsov dshevtsov deleted the ds_whatsnew branch July 8, 2019 19:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants