-
Notifications
You must be signed in to change notification settings - Fork 1.7k
What's New digest #4901
What's New digest #4901
Conversation
_data/whats-new.yml
Outdated
type: Major update | ||
date: June 28, 2019 | ||
link: https://github.com/magento/devdocs/pull/4850 | ||
- description: "- Documented the `{all}` route template option for the `routes.yaml` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this description enclosed in " "? In the PR, it's two bulleted items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The double quotes are added by the YAML formatter automatically. I assume that this is done because the string starts with -
and hyphen is a special symbol in YAML that indicates an array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so looking at a previous What's New entry that includes a list: #4839 -- looks like I need to add an opening sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is up to your choice. We do not have such requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK -- I updated it so the items would be in a list. Thanks.
_data/whats-new.yml
Outdated
type: Major update | ||
date: July 8, 2019 | ||
link: https://github.com/magento/devdocs/pull/4630 | ||
- description: Clarified the Functional testing for Docker is for ece-tools and not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heather is updating description to include link.
running tests |
Hi @dshevtsov, thank you for your contribution! |
Purpose of this pull request
This pull request updates the What's New page since last update on June 27.
Affected DevDocs pages