Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document catalog configuration added to storeConfig query #4920

Merged
merged 4 commits into from
Jul 25, 2019
Merged

Document catalog configuration added to storeConfig query #4920

merged 4 commits into from
Jul 25, 2019

Conversation

pmclain
Copy link
Contributor

@pmclain pmclain commented Jul 10, 2019 •
edited by meker12
Loading

Purpose of this pull request

This PR adds catalog configuration elements available in the storeConfig graphql query. These elements were added in magento/graphql-ce#650

Fixes magento/graphql-ce#768

Links to Magento source code

https://github.com/magento/graphql-ce/blob/9f2f5b605564465876b391883be3f19035b5f80a/app/code/Magento/CatalogGraphQl/etc/graphql/di.xml#L83-L97

whatsnew
Added catalog attributes to the storeConfig query in the GraphQL Developer Guide.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this Jul 10, 2019
@rogyar rogyar added Major Update Significant original updates to existing content 2.3.x Magento 2.3 related changes labels Jul 10, 2019
@keharper keharper self-assigned this Jul 16, 2019
keharper
keharper requested changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of applying real attribute descriptions. I hate that devdocs and the source differ. Someday I'll create a code PR to sync them up.

guides/v2.3/graphql/reference/store-config.md Outdated Show resolved Hide resolved
guides/v2.3/graphql/reference/store-config.md Outdated Show resolved Hide resolved
guides/v2.3/graphql/reference/store-config.md Outdated Show resolved Hide resolved
guides/v2.3/graphql/reference/store-config.md Outdated Show resolved Hide resolved
guides/v2.3/graphql/reference/store-config.md Outdated Show resolved Hide resolved
guides/v2.3/graphql/reference/store-config.md Outdated Show resolved Hide resolved
guides/v2.3/graphql/reference/store-config.md Outdated Show resolved Hide resolved
guides/v2.3/graphql/reference/store-config.md Outdated Show resolved Hide resolved
guides/v2.3/graphql/reference/store-config.md Show resolved Hide resolved
guides/v2.3/graphql/reference/store-config.md Show resolved Hide resolved
@keharper keharper added the Community Docs impacted by community code contribution label Jul 18, 2019
@keharper
Copy link
Contributor

running tests

@keharper keharper merged commit 9d8238d into magento:develop Jul 25, 2019
@ghost
Copy link

ghost commented Jul 25, 2019

Hi @pmclain, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper keharper mentioned this pull request Jul 25, 2019
Closed
@meker12
Copy link
Contributor

meker12 commented Aug 12, 2019

@keharper Missing whatsnew required for major updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@keharper keharper keharper approved these changes

Assignees

@rogyar rogyar

@keharper keharper

Labels
2.3.x Magento 2.3 related changes Community Docs impacted by community code contribution Major Update Significant original updates to existing content Partner: Something Digital partners-contribution PR created by Magento partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pmclain @devops-devdocs @keharper @meker12 @rogyar @magento-engcom-team