Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

magento/devdocs#: Docs: Add documentation for related/upsell/crosssell products (DEVELOP) #4986

Merged
merged 3 commits into from
Jul 25, 2019
Merged

magento/devdocs#: Docs: Add documentation for related/upsell/crosssell products (DEVELOP) #4986

merged 3 commits into from
Jul 25, 2019

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Jul 18, 2019 •
edited by keharper
Loading

Purpose of this pull request

This pull request (PR) provides docs for the magento/graphql-ce#766 issue.

Affected DevDocs pages

Links to Magento source code

  • ...

Thank you!

CC: @keharper @rogyar

whatsnew
Related items, up-sell, and cross-sell products are now supported in the products query.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@atwixfirster atwixfirster changed the title magento/devdocs#: Docs: Add documentation for related/upsell/crosssel… magento/devdocs#: Docs: Add documentation for related/upsell/crosssell products (DEVELOP) Jul 18, 2019
@atwixfirster atwixfirster mentioned this pull request Jul 18, 2019
Closed
@osrecio osrecio self-assigned this Jul 18, 2019
@osrecio osrecio added New Topic A major update published as an entirely new document Technical Updates to the code or processes that alter the technical content of the doc Major Update Significant original updates to existing content 2.3.x Magento 2.3 related changes labels Jul 18, 2019
@jeff-matthews jeff-matthews removed New Topic A major update published as an entirely new document Technical Updates to the code or processes that alter the technical content of the doc labels Jul 18, 2019
@keharper keharper self-assigned this Jul 18, 2019
rogyar
rogyar suggested changes Jul 19, 2019
View reviewed changes
@rogyar rogyar added the Waiting for Response Waiting for response from internal/external parties label Jul 19, 2019
osrecio
osrecio approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved this PR technically

@keharper keharper added xx2.3.3 Magento 2.3.3 changes and removed Waiting for Response Waiting for response from internal/external parties 2.3.x Magento 2.3 related changes labels Jul 25, 2019
keharper
keharper suggested changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this functionality has been merged into 2.3.3.

Just a few grammatical changes.

@keharper keharper mentioned this pull request Jul 25, 2019
Closed
@keharper
Copy link
Contributor

running tests

@keharper keharper merged commit 3ece0cb into magento:develop Jul 25, 2019
@ghost
Copy link

ghost commented Jul 25, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper
Copy link
Contributor

Thanks as always, @atwixfirster

@atwixfirster
Copy link
Contributor Author

Thanks as always, @atwixfirster

welcome as always , @keharper !

Thank you very much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@osrecio osrecio osrecio approved these changes

@rogyar rogyar rogyar approved these changes

@keharper keharper keharper approved these changes

Assignees

@osrecio osrecio

@rogyar rogyar

@keharper keharper

Labels
Major Update Significant original updates to existing content Partner: Atwix partners-contribution PR created by Magento partner xx2.3.3 Magento 2.3.3 changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@atwixfirster @devops-devdocs @keharper @osrecio @rogyar @jeff-matthews @magento-engcom-team