Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

GraphQL: Update ProductImage data type #5048

Merged
merged 12 commits into from
Aug 2, 2019
Merged

GraphQL: Update ProductImage data type #5048

merged 12 commits into from
Aug 2, 2019

Conversation

keharper
Copy link
Contributor

@keharper keharper commented Jul 25, 2019 •
edited
Loading

Purpose of this pull request

This pull request (PR) adds MediaGalleryInterface to the ProductInterface. The data type for image, small_image, and thumbnail has changed from ProductImage to MediaGalleryInterface. Also added the ProductVideo data type.

Affected DevDocs pages

whatsnew
Added MediaGalleryInterface as an output object for products queries.

@keharper keharper added Major Update Significant original updates to existing content Internal Dev Differentiates work between community and Magento staff xx2.3.3 Magento 2.3.3 changes labels Jul 25, 2019
@keharper keharper self-assigned this Jul 25, 2019
@keharper
Copy link
Contributor Author

Closing this. Development decided to handle the underlying issue in a different way.

@keharper keharper closed this Jul 25, 2019
@ghost
Copy link

ghost commented Jul 25, 2019

Hi @keharper, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper keharper reopened this Jul 26, 2019
@keharper keharper requested review from prabhuram93 and erikmarr July 29, 2019 21:02
erikmarr
erikmarr approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@erikmarr erikmarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@keharper
Copy link
Contributor Author

keharper commented Aug 2, 2019

running tests

1 similar comment
@keharper
Copy link
Contributor Author

keharper commented Aug 2, 2019

running tests

@keharper
Copy link
Contributor Author

keharper commented Aug 2, 2019

running tests

@keharper
Copy link
Contributor Author

keharper commented Aug 2, 2019

running tests

@keharper
Copy link
Contributor Author

keharper commented Aug 2, 2019

running tests

@keharper keharper merged commit e123b5e into develop Aug 2, 2019
@ghost
Copy link

ghost commented Aug 2, 2019

Hi @keharper, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper keharper deleted the kh_graphql-mediagallery branch August 2, 2019 18:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikmarr erikmarr erikmarr approved these changes

@prabhuram93 prabhuram93 Awaiting requested review from prabhuram93

Assignees

@keharper keharper

@erikmarr erikmarr

Labels
Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content xx2.3.3 Magento 2.3.3 changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keharper @erikmarr