This repository was archived by the owner on Nov 19, 2024. It is now read-only.
MAGECLOUD-3520 update screenshot, php lines, markdown #5123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hguthrie
added
the
Internal Dev
meker12
reviewed
Aug 10, 2019
meker12
suggested changes
Aug 12, 2019
Going to send this for another technical review.
meker12
approved these changes
Aug 12, 2019
NadiyaS
reviewed
Aug 13, 2019
NadiyaS
reviewed
Aug 13, 2019
NadiyaS
reviewed
Aug 13, 2019
NadiyaS
reviewed
Aug 13, 2019
NadiyaS
reviewed
Aug 13, 2019
| From: | ||
|
|
||
| ```php?start_inline=1 | ||
| return strpos(str_replace('---', '.', $_SERVER['HTTP_HOST']), $host) === 0; |
There was a problem hiding this comment.
I guess we need to change it in the file itself. Do not see reasons to keep example with ---.
Will create ticket.
NadiyaS
reviewed
Aug 13, 2019
|
Yay! Major technical updates completed! @meker12 You are welcome to review again, if you like. Otherwise, this is ready to go! |
|
running tests |
meker12
reviewed
Aug 15, 2019
|
|
||
| ### Configure locations for shared domains {#locations} | ||
|
|
||
| Where the routes configuration defines how the URLs are processed, the `web` property in the `.magento.app.yaml` file defines how your application is exposed to the web. Web _locations_ allows more granularity for incoming requests. For example, if your domain is `store.com`, you can use `/first` (default site) and `/second` for requests to two different stores that share the same domain. |
There was a problem hiding this comment.
Suggested change
| Where the routes configuration defines how the URLs are processed, the `web` property in the `.magento.app.yaml` file defines how your application is exposed to the web. Web _locations_ allows more granularity for incoming requests. For example, if your domain is `store.com`, you can use `/first` (default site) and `/second` for requests to two different stores that share the same domain. | |
| Where the routes configuration defines how the URLs are processed, the `web` property in the `.magento.app.yaml` file defines how your application is exposed to the web. Web _locations_ allow more granularity for incoming requests. For example, if your domain is `store.com`, you can use `/first` (default site) and `/second` for requests to two different stores that share the same domain. |
There was a problem hiding this comment.
I saw this after the test run, but yes, this is tricky. Locations is a web property category. The brain can get confused here. I'd like to find a way to get rid of Allow. I don't like using that word, in fact. Maybe provides.... ugh, staring too long...
|
Hi @hguthrie, thank you for your contribution! |
NadiyaS
approved these changes
Aug 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the inaccuracies related to multi-sites outlined in the MAGECLOUD-3520:
whatsnew
Updated the Set up multiple website or stores topic in the Cloud guide. Now, this topic differentiates between sites with a shared domain and sites with unique domains.