Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGECLOUD-3520 update screenshot, php lines, markdown #5123

Merged
merged 9 commits into from Aug 15, 2019

Conversation

@hguthrie
Copy link
Contributor

commented Aug 5, 2019

This PR updates the inaccuracies related to multi-sites outlined in the MAGECLOUD-3520:

  • update screenshot in Config guide
  • PHP code snippet formatting fixes
  • fix multi-site by differentiating between sites with shared domain and sites with unique domains

whatsnew
Updated the Set up multiple website or stores topic in the Cloud guide. Now, this topic differentiates between sites with a shared domain and sites with unique domains.

@hguthrie hguthrie self-assigned this Aug 5, 2019

@m2-community-project m2-community-project bot added this to Review in Progress in Pull Request Progress Aug 5, 2019

hguthrie added 3 commits Aug 9, 2019

@hguthrie hguthrie requested review from andriyShevtsov and meker12 Aug 9, 2019

@hguthrie hguthrie marked this pull request as ready for review Aug 9, 2019

fix some incorrect statements and typos
Going to send this for another technical review.
From:

```php?start_inline=1
return strpos(str_replace('---', '.', $_SERVER['HTTP_HOST']), $host) === 0;

This comment has been minimized.

Copy link
@NadiyaS

NadiyaS Aug 13, 2019

Contributor

I guess we need to change it in the file itself. Do not see reasons to keep example with ---.
Will create ticket.

hguthrie added 3 commits Aug 14, 2019
@hguthrie

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

Yay! Major technical updates completed! @meker12 You are welcome to review again, if you like. Otherwise, this is ready to go!

@hguthrie

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

running tests


### Configure locations for shared domains {#locations}

Where the routes configuration defines how the URLs are processed, the `web` property in the `.magento.app.yaml` file defines how your application is exposed to the web. Web _locations_ allows more granularity for incoming requests. For example, if your domain is `store.com`, you can use `/first` (default site) and `/second` for requests to two different stores that share the same domain.

This comment has been minimized.

Copy link
@meker12

meker12 Aug 15, 2019

Contributor
Suggested change
Where the routes configuration defines how the URLs are processed, the `web` property in the `.magento.app.yaml` file defines how your application is exposed to the web. Web _locations_ allows more granularity for incoming requests. For example, if your domain is `store.com`, you can use `/first` (default site) and `/second` for requests to two different stores that share the same domain.
Where the routes configuration defines how the URLs are processed, the `web` property in the `.magento.app.yaml` file defines how your application is exposed to the web. Web _locations_ allow more granularity for incoming requests. For example, if your domain is `store.com`, you can use `/first` (default site) and `/second` for requests to two different stores that share the same domain.

This comment has been minimized.

Copy link
@hguthrie

hguthrie Aug 15, 2019

Author Contributor

I saw this after the test run, but yes, this is tricky. Locations is a web property category. The brain can get confused here. I'd like to find a way to get rid of Allow. I don't like using that word, in fact. Maybe provides.... ugh, staring too long...

@hguthrie hguthrie merged commit 1f18c1a into master Aug 15, 2019

2 checks passed

Jenkins Tests passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

commented Aug 15, 2019

Hi @hguthrie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Review in Progress to Done in Pull Request Progress Aug 15, 2019

@hguthrie hguthrie deleted the hg-mc3520-inaccuracies branch Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.