Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RowBuilder widget documentation #5206

Conversation

@devops-devdocs

This comment has been minimized.

Copy link

commented Aug 19, 2019

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this Aug 19, 2019

@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Aug 19, 2019

@rogyar

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

Hi @serhiyzhovnir. Thank you for the great topic. Please, perform a few minor adjustments and we are good to go.

@serhiyzhovnir

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

Hi @rogyar
The PR was adjusted. Please, review it again.
Thank you!

@rogyar
rogyar approved these changes Aug 20, 2019
@jeff-matthews
Copy link
Contributor

left a comment

Thanks for the new topic @serhiyzhovnir! I made some minor editorial suggestions.

@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Request Progress Aug 23, 2019

@serhiyzhovnir

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2019

Hi @jeff-matthews
The PR was adjusted.
Thank you!

@jeff-matthews
Copy link
Contributor

left a comment

Thanks @serhiyzhovnir!

@jeff-matthews jeff-matthews moved this from Changes Requested to Acceptance Testing in Pull Request Progress Aug 26, 2019

@jeff-matthews
Copy link
Contributor

left a comment

@serhiyzhovnir, I just noticed some markdown syntax errors in your branch that will fail tests. Please fix these issues so I can finish processing:

 rake test:cicd
Testing Markdown style with mdl ...
guides/v2.2/javascript-dev-guide/widgets/widget-row-builder.md:44: MD009 Trailing spaces
guides/v2.3/javascript-dev-guide/widgets/widget-row-builder.md:44: MD009 Trailing spaces

A detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

The Markdown linter has found 4 issues
@serhiyzhovnir

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

Hi @jeff-matthews
The trailing spaces were removed.
Please, check the PR again.
Thank you!

@jeff-matthews
Copy link
Contributor

left a comment

Confirmed. Thanks @serhiyzhovnir!

@jeff-matthews

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

running tests

@jeff-matthews jeff-matthews merged commit f9abc7b into magento:master Aug 26, 2019

2 checks passed

Jenkins Tests passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

commented Aug 26, 2019

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.