Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the documentation for multiselect widget #5207

Conversation

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Aug 19, 2019
@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this Aug 19, 2019
@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Aug 19, 2019
@rogyar rogyar added 2.2.x 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc New Topic A major update published as an entirely new document labels Aug 19, 2019
@rogyar
Copy link
Contributor

rogyar commented Aug 19, 2019

Hi @serhiyzhovnir. As always, thank you for the great topic!

@serhiyzhovnir
Copy link
Contributor Author

Hi @rogyar
We have improved the explanations of mselectCheckedClass, containerClass, currentPage, lastAppendValue options.
Please, check it again.
Thank you!

@rogyar
Copy link
Contributor

rogyar commented Aug 20, 2019

Awesome, thank you

@jeff-matthews jeff-matthews removed the Technical Updates to the code or processes that alter the technical content of the doc label Aug 23, 2019
@m2-community-project m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Aug 23, 2019
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new topic @serhiyzhovnir! I made a few editorial suggestions.

@serhiyzhovnir
Copy link
Contributor Author

@jeff-matthews
This PR is adjusted.
Please, let me know if I need to add some additional changes.
Thank you!

@jeff-matthews jeff-matthews moved this from Changes Requested to Acceptance Testing in Pull Request Progress Aug 26, 2019
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serhiyzhovnir, I just noticed some markdown syntax errors on your branch that will fail tests. Please fix the following issues so I can finish processing your PR:

rake test:cicd
Testing Markdown style with mdl ...
guides/v2.2/javascript-dev-guide/widgets/widget-multiselect.md:35: MD009 Trailing spaces
guides/v2.3/javascript-dev-guide/widgets/widget-multiselect.md:35: MD009 Trailing spaces

A detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

The Markdown linter has found 4 issues

@serhiyzhovnir
Copy link
Contributor Author

Hi @jeff-matthews
The trailing spaces were removed.
Please, check the PR again.
Thank you!

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. Thanks @serhiyzhovnir!

@jeff-matthews
Copy link
Contributor

running tests

Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serhiyzhovnir, tests are failing on broke links:

Running ["LinkChecker::DoubleSlashCheck", "HtmlCheck", "ImageCheck", "LinkCheck", "ScriptCheck"] on ["_site"] on *.html... 


Ran on 2809 files!


- linking to internal hash #updateDelay that does not exist
  *  _site/guides/v2.2/javascript-dev-guide/widgets/widget-multiselect.html (line 275)
     <a href="#updateDelay">updateDelay</a>
  *  _site/guides/v2.3/javascript-dev-guide/widgets/widget-multiselect.html (line 275)
     <a href="#updateDelay">updateDelay</a>
rake aborted!
HTML-Proofer found 2 failures!``` 

@serhiyzhovnir
Copy link
Contributor Author

Hi @jeff-matthews
The issue with the updateDelay link was fixed.
Thank you!

@jeff-matthews
Copy link
Contributor

running tests

@jeff-matthews jeff-matthews merged commit e8168f4 into magento:master Aug 27, 2019
@ghost
Copy link

ghost commented Aug 27, 2019

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Acceptance Testing to Done in Pull Request Progress Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.2.x 2.3.x Magento 2.3 related changes New Topic A major update published as an entirely new document Partner: Atwix partners-contribution PR created by Magento partner
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants