Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update section about exceptions #5209

Merged
merged 8 commits into from Aug 23, 2019

Conversation

@melnikovi
Copy link
Member

commented Aug 19, 2019

Purpose of this pull request

Update section about exceptions in technical guidelines.

Affected DevDocs pages

Links to Magento source code

  • ...

whatsnew
Added a technical guideline (clause 5.20) about how to handle exceptions in observers and plugins.

@magento-cicd2

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

jeff-matthews
dshevtsov
melnikovi

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Aug 19, 2019

@devops-devdocs

This comment has been minimized.

Copy link

commented Aug 19, 2019

An admin must run tests on this PR before it can be merged.

@buskamuza buskamuza requested a review from maghamed Aug 19, 2019

@dshevtsov dshevtsov self-assigned this Aug 19, 2019

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Aug 19, 2019

@dshevtsov
Copy link
Contributor

left a comment

Please consider splitting into two statements and avoiding passive voice and nested semantical recursions:

Plugins MUST throw only exceptions declared by the method to which the plugins are added.
Observers MUST throw only exceptions declared by the method that triggers an event.

Discussed with @melnikovi .

@melnikovi melnikovi force-pushed the magento-architects:exceptions branch from 9389ce1 to b9e57ce Aug 19, 2019

@skinlikeporcelain

This comment has been minimized.

Plugin exceptions to trigger an event

@dshevtsov dshevtsov requested a review from erikmarr Aug 19, 2019

@erikmarr
Copy link
Contributor

left a comment

Looks good! Just a minor word order swap.

guides/v2.2/coding-standards/technical-guidelines.md Outdated Show resolved Hide resolved
Change wording
Co-Authored-By: Erik Marr <45772211+erikmarr@users.noreply.github.com>
@jeff-matthews

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

running tests

@dshevtsov dshevtsov added Major update and removed Technical labels Aug 22, 2019

@dshevtsov

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

@jeff-matthews this pull request still requires a review form an architect @maghamed .

@jeff-matthews

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

Thanks @dshevtsov. I forgot that all architect reviewers must approve; not just one.

Waiting for your approval @maghamed.

@dshevtsov

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

running tests

@dshevtsov

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

running tests

@dshevtsov

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

running tests

@dshevtsov dshevtsov self-requested a review Aug 23, 2019

@dshevtsov dshevtsov merged commit de6f27a into magento:master Aug 23, 2019

1 of 2 checks passed

licence/cla Contributor License Agreement is not signed yet.
Details
Jenkins Tests passed
Details
@contribution-survey

This comment has been minimized.

Copy link

commented Aug 23, 2019

Hi @melnikovi, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.