Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example of mixin for jQuery Widget #5229

Conversation

@devops-devdocs

This comment has been minimized.

Copy link

commented Aug 21, 2019

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this Aug 21, 2019

@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Aug 21, 2019

@rogyar

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

Hi @serhiyzhovnir. Thank you for the great examples!

@rogyar
rogyar approved these changes Aug 21, 2019
@serhiyzhovnir

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

Hi @jeff-matthews
The PR was adjusted.
Thank you!

@jeff-matthews
Copy link
Contributor

left a comment

Thanks @serhiyzhovnir. I checked your branch locally and discovered some markdown linting errors similar to #5230. Our test system runs rake test:cicd, which now includes markdown linting in addition to link checking.

Please fix the following issues:

guides/v2.2/javascript-dev-guide/javascript/js_mixins.md:86: MD009 Trailing spaces
guides/v2.3/javascript-dev-guide/javascript/js_mixins.md:86: MD009 Trailing spaces

A detailed description of the rules is available at http://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md
@serhiyzhovnir

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2019

Hi @jeff-matthews
The issue with trailing spaces was fixed.
Thanks!

@jeff-matthews jeff-matthews moved this from Changes Requested to Acceptance Testing in Pull Request Progress Aug 26, 2019

@jeff-matthews

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

running tests

@jeff-matthews jeff-matthews merged commit b6fa1a6 into magento:master Aug 26, 2019

2 checks passed

Jenkins Tests passed
Details
licence/cla Contributor License Agreement is signed.
Details
@contribution-survey

This comment has been minimized.

Copy link

commented Aug 26, 2019

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Acceptance Testing to Done in Pull Request Progress Aug 26, 2019

@serhiyzhovnir serhiyzhovnir deleted the serhiyzhovnir:add-example-of-mixin-for-jquery-widget branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.