Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Conversation

serhiyzhovnir
Copy link
Contributor

@serhiyzhovnir serhiyzhovnir commented Sep 11, 2019

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.


### `clearMultiselectOptions()`

The method clears all multi-select items.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify this point, please? The "clears" means deselect items or remove them?
Thank you

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The clearMultiselectOptions() method removes all multi-select items. The description of this method already adjusted. Thank you!

@rogyar rogyar added 2.2.x 2.3.x Magento 2.3 related changes Technical Updates to the code or processes that alter the technical content of the doc Major Update Significant original updates to existing content labels Sep 11, 2019
Copy link
Contributor

@dobooth dobooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please alphabetize the methods list. If you want to be a real hero, alphabetizing the options would be fantastic.

@hguthrie hguthrie removed the Technical Updates to the code or processes that alter the technical content of the doc label Sep 12, 2019
@serhiyzhovnir
Copy link
Contributor Author

Hello @dobooth
The lists of options and methods were sorted.
Thank you!

@serhiyzhovnir
Copy link
Contributor Author

Hey @dobooth
This PR is ready for your review.
Let me know if I need to add some additional modifications.
Thank you!

@dobooth
Copy link
Contributor

dobooth commented Sep 19, 2019

running tests

@dobooth
Copy link
Contributor

dobooth commented Sep 19, 2019

running tests

@dobooth dobooth merged commit 106a02a into magento:master Sep 19, 2019
@meker12
Copy link
Contributor

meker12 commented Sep 20, 2019

@dobooth Please add whatsnew, thx.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.2.x 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Atwix partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants