This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Add store name to store config query schema #5448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Something Digital
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
|
Rebased to Q4-integration, but not merged because I need to confirm whether the code PR will make it into 2.3.4. |
keharper
added
Community
keharper
approved these changes
Oct 4, 2019
|
Hi @pmclain, thank you for your contribution! |
|
Confirmed this will be in 2.3.4. Merging. Thanks @pmclain |
keharper
added a commit
that referenced
this pull request
Oct 8, 2019
* update deprecated description * Revert "update deprecated description" This reverts commit c9b39a0. * GraphQL: update description of deprecated directive (#5213) * update deprecated description * review comments * MC-19250: The stuck deployment on the Cloud because of consumers (#5289) * MC-19250: The stuck deployment on the Cloud because of consumers * Update _includes/config/consumers.md Co-Authored-By: Margaret Eker <meker@adobe.com> * GraphQL: Add layered navigation documentation (#5222) * add filtering example * checkpoint * checkpoint * checkpoint * checkpoint * checkpoint * checkpoint * checkpoint * checkpoint * checkpoint * linting errors * fix link * update opening sentence * remove bogus commit * Apply suggestions from code review Co-Authored-By: Erik Marr <45772211+erikmarr@users.noreply.github.com> * change code gates * final review comments * deprecation notices (#5413) * review draft (#5426) * GraphQL: Add fields and example showing cart rule discounts (#5425) * review draft * minor tweaks * review comment * update example * MC-18725: Write article with clarification of how to use this functionality * MC-18725: Write article with clarification of how customer data works * MC-18725: Write article with clarification of how customer data works * Small grammar changes. * GraphQL: Update pricing schema changes (#5512) * checkpoint * checkpoint * minor updates * review comments * one more review comment * more review comments * correct linting error * remove stray character from TOC * Add store name to store config query schema (#5448) * GraphQL: Add categoryList query (#5562) * checkpoint * review draft * fix linting errors * add to list of cached queries * update example to show usage of * clarify match filters * Apply suggestions from code review Added review comments Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com> * update sample * rename file * review comment from Dan * developer feedback * resolve more merge conflicts * linting errors * linting errors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Adds
store_nameproperty tostoreConfigquery.Depends magento/graphql-ce#952
Affected DevDocs pages
whatsnew
Added the
store_nameattribute to the storeConfig query.