Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Converted the Change Fastly credentials KB article to DevDocs #5501

Merged
merged 8 commits into from
Oct 1, 2019

Conversation

meker12
Copy link
Contributor

@meker12 meker12 commented Sep 27, 2019

@meker12 meker12 self-assigned this Sep 27, 2019
@meker12 meker12 added Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content 2.x and removed Progress: review labels Sep 27, 2019
@meker12 meker12 requested a review from hguthrie September 27, 2019 03:59
Copy link
Contributor

@hguthrie hguthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. There was one paragraph that was confusing, but otherwise, looks clean.

meker12 and others added 2 commits September 27, 2019 09:31
Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com>
@meker12
Copy link
Contributor Author

meker12 commented Sep 27, 2019

running tests

@@ -16,7 +16,7 @@ rule 'MD019'
exclude_rule 'MD020'
exclude_rule 'MD021'
exclude_rule 'MD022'
exclude_rule 'MD023'
rule 'MD023'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this part of the PR?

@meker12
Copy link
Contributor Author

meker12 commented Oct 1, 2019

running tests

@meker12 meker12 merged commit 58d728b into master Oct 1, 2019
@ghost
Copy link

ghost commented Oct 1, 2019

Hi @meker12, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@meker12 meker12 deleted the mae-magedoc-4005-KB-conversion-fastly-credentials branch October 1, 2019 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants