This repository was archived by the owner on Nov 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Converted the Change Fastly credentials KB article to DevDocs #5501
Merged
meker12
merged 8 commits into
master
from
mae-magedoc-4005-KB-conversion-fastly-credentials
Oct 1, 2019
Merged
Converted the Change Fastly credentials KB article to DevDocs #5501
meker12
merged 8 commits into
master
from
mae-magedoc-4005-KB-conversion-fastly-credentials
Oct 1, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hguthrie
approved these changes
Sep 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. There was one paragraph that was confusing, but otherwise, looks clean.
Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com>
meker12
commented
Sep 27, 2019
running tests |
…ithub.com:magento/devdocs into mae-magedoc-4005-KB-conversion-fastly-credentials
hguthrie
reviewed
Sep 30, 2019
_checks/styles/style-rules-prod
Outdated
@@ -16,7 +16,7 @@ rule 'MD019' | |||
exclude_rule 'MD020' | |||
exclude_rule 'MD021' | |||
exclude_rule 'MD022' | |||
exclude_rule 'MD023' | |||
rule 'MD023' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this part of the PR?
running tests |
Hi @meker12, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
2.x
Internal Dev
Differentiates work between community and Magento staff
Major Update
Significant original updates to existing content
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Converted Change account owner access credentials via API tokens for Fastly on Cloud KB article to a DevDocs topic.
Affected DevDocs pages
whatsnew
Added instructions for changing the Fastly API token credential to the Cloud Guide.