Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Shopping ads Update #5568

Merged
merged 5 commits into from Oct 7, 2019
Merged

Google Shopping ads Update #5568

merged 5 commits into from Oct 7, 2019

Conversation

hickskenh
Copy link
Contributor

@hickskenh hickskenh commented Oct 4, 2019

Purpose of this pull request

This pull request (PR) adds release notes for Google Shopping ads 3.0.1, updates the install guide to remove API Key info and refer users to the same topic in Merchdocs, and updates the Release page (along with the compatability.yml).

Affected DevDocs pages

whatsnew
Added Release Notes for Google Shopping ads Channel v3.0.1 to the Extension Developer Guide.

- Added Release notes for 3.0.1
- Updated Install to remove API key instructions and refer to same topic in merchdocs
- updated release page
@hickskenh hickskenh added Major Update Significant original updates to existing content xx2.3.3 Magento 2.3.3 changes labels Oct 4, 2019
@hickskenh hickskenh requested a review from a team October 4, 2019 14:49
@hickskenh hickskenh self-assigned this Oct 4, 2019
@m2-community-project m2-community-project bot added this to Review in Progress in Pull Request Progress Oct 4, 2019
extensions/google-shopping-ads/index.md Outdated Show resolved Hide resolved
extensions/google-shopping-ads/release-notes/index.md Outdated Show resolved Hide resolved
extensions/google-shopping-ads/release-notes/index.md Outdated Show resolved Hide resolved
hickskenh and others added 4 commits October 7, 2019 09:16
Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
@hickskenh
Copy link
Contributor Author

running tests

@hickskenh hickskenh merged commit 904253a into develop Oct 7, 2019
@ghost
Copy link

ghost commented Oct 7, 2019

Hi @hickskenh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@hickskenh hickskenh deleted the google-shopping-301-rn branch October 7, 2019 15:13
@m2-community-project m2-community-project bot moved this from Changes Requested to Done in Pull Request Progress Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Major Update Significant original updates to existing content xx2.3.3 Magento 2.3.3 changes
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants