New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Shopping ads Update #5568
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Release notes for 3.0.1 - Updated Install to remove API key instructions and refer to same topic in merchdocs - updated release page
hickskenh
added
Major Update
Significant original updates to existing content
xx2.3.3
Magento 2.3.3 changes
labels
Oct 4, 2019
jeff-matthews
requested changes
Oct 7, 2019
m2-community-project
bot
moved this from Review in Progress
to Changes Requested
in Pull Request Progress
Oct 7, 2019
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
Oct 7, 2019
Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
Co-Authored-By: Jeff Matthews <matthews.jeffery@gmail.com>
jeff-matthews
approved these changes
Oct 7, 2019
running tests |
Hi @hickskenh, thank you for your contribution! |
m2-community-project
bot
moved this from Changes Requested
to Done
in Pull Request Progress
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) adds release notes for Google Shopping ads 3.0.1, updates the install guide to remove API Key info and refer users to the same topic in Merchdocs, and updates the Release page (along with the compatability.yml).
Affected DevDocs pages
whatsnew
Added Release Notes for Google Shopping ads Channel v3.0.1 to the Extension Developer Guide.